Skip to content

Try to validate read ts for all RPC requests (#1513)#1558

Merged
ti-chi-bot[bot] merged 2 commits intotikv:tidb-6.5from
ekexium:tidb-6.5-pick-1513-1533
Jan 16, 2025
Merged

Try to validate read ts for all RPC requests (#1513)#1558
ti-chi-bot[bot] merged 2 commits intotikv:tidb-6.5from
ekexium:tidb-6.5-pick-1513-1533

Conversation

@ekexium
Copy link
Contributor

@ekexium ekexium commented Jan 15, 2025

Cherry pick #1513 and #1533 to tidb-6.5.

@ti-chi-bot ti-chi-bot bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Jan 15, 2025
@ekexium ekexium requested a review from you06 January 15, 2025 10:34
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 15, 2025
@ekexium ekexium requested a review from MyonKeminta January 15, 2025 10:34
@you06 @MyonKeminta @ekexium
Try to validate read ts for all RPC requests (tikv#1513) (tikv#1546)
d0b21cf 
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: you06 <you1474600@gmail.com>

Co-authored-by: MyonKeminta <9948422+MyonKeminta@users.noreply.github.com>
@ekexium ekexium force-pushed the tidb-6.5-pick-1513-1533 branch from 3de2311 to d0b21cf Compare January 15, 2025 10:36
@ekexium
fix lint
5fd5b6f 
Signed-off-by: ekexium <eke@fastmail.com>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 16, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MyonKeminta, you06

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 16, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 16, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-16 07:34:57.725482289 +0000 UTC m=+190369.180528423: ☑️ agreed by you06.
  • 2025-01-16 08:04:13.476094784 +0000 UTC m=+192124.931140933: ☑️ agreed by MyonKeminta.

@ti-chi-bot ti-chi-bot bot merged commit ec354dc into tikv:tidb-6.5 Jan 16, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@you06 you06 you06 approved these changes

@MyonKeminta MyonKeminta MyonKeminta approved these changes

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ekexium @you06 @MyonKeminta