oracle: setLastTS always push tso to higher value#1533
Merged
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom Dec 20, 2024
Merged
oracle: setLastTS always push tso to higher value#1533ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
setLastTS always push tso to higher value#1533ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
Conversation
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
MyonKeminta
approved these changes
Dec 20, 2024
crazycs520
approved these changes
Dec 20, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crazycs520, MyonKeminta The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
crazycs520
pushed a commit
to crazycs520/client-go
that referenced
this pull request
Dec 20, 2024
crazycs520
pushed a commit
to crazycs520/client-go
that referenced
this pull request
Dec 20, 2024
you06-pingcap
pushed a commit
to you06/client-go
that referenced
this pull request
Jan 7, 2025
you06-pingcap
pushed a commit
to you06/client-go
that referenced
this pull request
Jan 7, 2025
you06-pingcap
pushed a commit
to you06/client-go
that referenced
this pull request
Jan 7, 2025
you06-pingcap
pushed a commit
to you06/client-go
that referenced
this pull request
Jan 7, 2025
This was referenced Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref pingcap/tidb#57786
The
setLastTScan be called concurrently, so that thetsoandarrivalmay have different order,lastTSO1.tso < lastTSO2.tsomeanwhilelastTSO1.arrival > lastTSO2.arrival. In this case, whenlastTSis set tolastTSO1, the update oflastTSO2will fail and later when we checklastTS, it's not true last.This PR changes the
setLastTSthat it'll always push thelastTSto the max TSO we received.