Try to validate read ts for all RPC requests (#1513)#1549
Try to validate read ts for all RPC requests (#1513)#1549ti-chi-bot[bot] merged 4 commits intotikv:tidb-8.5from
Conversation
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: you06 <you1474600@gmail.com>
Signed-off-by: you06 <you1474600@gmail.com>
| if !exists || readTS > latestTSInfo.tso { | ||
| currentTS, err := o.getCurrentTSForValidation(ctx, opt) | ||
| if err != nil { | ||
| return errors.Errorf("fail to validate read timestamp: %v", err) |
There was a problem hiding this comment.
Maybe attach more information here as the read request would be rejected in this case?
There was a problem hiding this comment.
The log didn't exist in master branch. I think it's better to add it to master first and then cherry-pick it if necessary.
There was a problem hiding this comment.
If this branch is reached, the user client may receive this error. Is this situation always unexpected? Could it lead to false-positive judgments or similar issues?
I understand that it is indeed unexpected because each PD fetched timestamp will update the last TS first, Do I understand right?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekexium, MyonKeminta The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Cherry pick #1513 and #1533 to
tidb-8.5.