Skip to content

collecting the RU information by pasing point through context.Value#1032

Merged
iosmanthus merged 6 commits intotikv:cse-region-clientfrom
zeminzhou:context-ru-key-cse5
Nov 6, 2023
Merged

collecting the RU information by pasing point through context.Value#1032
iosmanthus merged 6 commits intotikv:cse-region-clientfrom
zeminzhou:context-ru-key-cse5

Conversation

@zeminzhou
Copy link
Contributor

@zeminzhou zeminzhou commented Oct 25, 2023

To collect all query RU consumption into statement log, ref https://github.com/tidbcloud/tidb-cse/pull/678

Signed-off-by: zzm <zhouzemin@pingcap.com>
Signed-off-by: zzm <zhouzemin@pingcap.com>
Signed-off-by: zzm <zhouzemin@pingcap.com>
Signed-off-by: zzm <zhouzemin@pingcap.com>
Signed-off-by: zzm <zhouzemin@pingcap.com>
@zeminzhou zeminzhou changed the title ru detail show RU consumption in stmtment log Oct 27, 2023
@zeminzhou zeminzhou changed the title show RU consumption in stmtment log collecting the RU information by pasing point through context.Value Oct 27, 2023
Signed-off-by: zzm <zhouzemin@pingcap.com>
wg.Wait()
}

func (s *KVStore) ruRuntimeStatsMapCleaner() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove those code?

@iosmanthus iosmanthus merged commit a29e95d into tikv:cse-region-client Nov 6, 2023
@zeminzhou zeminzhou deleted the context-ru-key-cse5 branch November 6, 2023 10:09
zeminzhou added a commit to zeminzhou/client-go that referenced this pull request Nov 21, 2023
…ikv#1032)

* ru detail

Signed-off-by: zzm <zhouzemin@pingcap.com>

* remove unused code

Signed-off-by: zzm <zhouzemin@pingcap.com>

* reduce waitgroup

Signed-off-by: zzm <zhouzemin@pingcap.com>

* fix ut

Signed-off-by: zzm <zhouzemin@pingcap.com>

* make lint

Signed-off-by: zzm <zhouzemin@pingcap.com>

* fix ci

Signed-off-by: zzm <zhouzemin@pingcap.com>

---------

Signed-off-by: zzm <zhouzemin@pingcap.com>
iosmanthus pushed a commit that referenced this pull request Nov 21, 2023
* collecting the RU information by pasing point through context.Value (#1032)

* ru detail

Signed-off-by: zzm <zhouzemin@pingcap.com>

* remove unused code

Signed-off-by: zzm <zhouzemin@pingcap.com>

* reduce waitgroup

Signed-off-by: zzm <zhouzemin@pingcap.com>

* fix ut

Signed-off-by: zzm <zhouzemin@pingcap.com>

* make lint

Signed-off-by: zzm <zhouzemin@pingcap.com>

* fix ci

Signed-off-by: zzm <zhouzemin@pingcap.com>

---------

Signed-off-by: zzm <zhouzemin@pingcap.com>

* don't change compatibility test

Signed-off-by: zzm <zhouzemin@pingcap.com>

---------

Signed-off-by: zzm <zhouzemin@pingcap.com>
glorv pushed a commit to glorv/client-go that referenced this pull request Dec 4, 2023
bufferflies pushed a commit that referenced this pull request Dec 4, 2023
* collecting the RU information by pasing point through context.Value (#1032)

Signed-off-by: zzm <zhouzemin@pingcap.com>

* add ruWaitDuration to RUDetails and update pd-client

Signed-off-by: glorv <glorvs@163.com>

---------

Signed-off-by: zzm <zhouzemin@pingcap.com>
Signed-off-by: glorv <glorvs@163.com>
Co-authored-by: zzm <zhouzemin@pingcap.com>
iosmanthus pushed a commit to iosmanthus/client-go that referenced this pull request Dec 21, 2023
* collecting the RU information by pasing point through context.Value (tikv#1032)

Signed-off-by: zzm <zhouzemin@pingcap.com>

* add ruWaitDuration to RUDetails and update pd-client

Signed-off-by: glorv <glorvs@163.com>

---------

Signed-off-by: zzm <zhouzemin@pingcap.com>
Signed-off-by: glorv <glorvs@163.com>
Co-authored-by: zzm <zhouzemin@pingcap.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
nolouch pushed a commit to nolouch/client-go that referenced this pull request Feb 2, 2024
* collecting the RU information by pasing point through context.Value (tikv#1032)

Signed-off-by: zzm <zhouzemin@pingcap.com>

* add ruWaitDuration to RUDetails and update pd-client

Signed-off-by: glorv <glorvs@163.com>

---------

Signed-off-by: zzm <zhouzemin@pingcap.com>
Signed-off-by: glorv <glorvs@163.com>
Co-authored-by: zzm <zhouzemin@pingcap.com>
glorv added a commit that referenced this pull request Feb 18, 2024
…#1151)

* resource_control: add ru details in ExecDetails (#1070)

* collecting the RU information by pasing point through context.Value (#1032)

Signed-off-by: zzm <zhouzemin@pingcap.com>

* add ruWaitDuration to RUDetails and update pd-client

Signed-off-by: glorv <glorvs@163.com>

---------

Signed-off-by: zzm <zhouzemin@pingcap.com>
Signed-off-by: glorv <glorvs@163.com>
Co-authored-by: zzm <zhouzemin@pingcap.com>

* use latest pd-client of release-7.5

Signed-off-by: nolouch <nolouch@gmail.com>

---------

Signed-off-by: zzm <zhouzemin@pingcap.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: nolouch <nolouch@gmail.com>
Co-authored-by: glorv <glorvs@163.com>
Co-authored-by: zzm <zhouzemin@pingcap.com>
zeminzhou added a commit to zeminzhou/client-go that referenced this pull request Feb 28, 2024
* collecting the RU information by pasing point through context.Value (tikv#1032)

Signed-off-by: zzm <zhouzemin@pingcap.com>

* add ruWaitDuration to RUDetails and update pd-client

Signed-off-by: glorv <glorvs@163.com>

---------

Signed-off-by: zzm <zhouzemin@pingcap.com>
Signed-off-by: glorv <glorvs@163.com>
Co-authored-by: zzm <zhouzemin@pingcap.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
zeminzhou added a commit to zeminzhou/client-go that referenced this pull request Feb 28, 2024
* collecting the RU information by pasing point through context.Value (tikv#1032)

Signed-off-by: zzm <zhouzemin@pingcap.com>

* add ruWaitDuration to RUDetails and update pd-client

Signed-off-by: glorv <glorvs@163.com>

---------

Signed-off-by: zzm <zhouzemin@pingcap.com>
Signed-off-by: glorv <glorvs@163.com>
Co-authored-by: zzm <zhouzemin@pingcap.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
zeminzhou added a commit to zeminzhou/client-go that referenced this pull request Feb 28, 2024
* collecting the RU information by pasing point through context.Value (tikv#1032)

Signed-off-by: zzm <zhouzemin@pingcap.com>

* add ruWaitDuration to RUDetails and update pd-client

Signed-off-by: glorv <glorvs@163.com>

---------

Signed-off-by: zzm <zhouzemin@pingcap.com>
Signed-off-by: glorv <glorvs@163.com>
Co-authored-by: zzm <zhouzemin@pingcap.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
zeminzhou added a commit to zeminzhou/client-go that referenced this pull request Feb 28, 2024
) (tikv#1151)

* resource_control: add ru details in ExecDetails (tikv#1070)

* collecting the RU information by pasing point through context.Value (tikv#1032)

Signed-off-by: zzm <zhouzemin@pingcap.com>

* add ruWaitDuration to RUDetails and update pd-client

Signed-off-by: glorv <glorvs@163.com>

---------

Signed-off-by: zzm <zhouzemin@pingcap.com>
Signed-off-by: glorv <glorvs@163.com>
Co-authored-by: zzm <zhouzemin@pingcap.com>

* use latest pd-client of release-7.5

Signed-off-by: nolouch <nolouch@gmail.com>

---------

Signed-off-by: zzm <zhouzemin@pingcap.com>
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: nolouch <nolouch@gmail.com>
Co-authored-by: glorv <glorvs@163.com>
Co-authored-by: zzm <zhouzemin@pingcap.com>
Signed-off-by: zzm <zhouzemin@pingcap.com>
zeminzhou added a commit to zeminzhou/client-go that referenced this pull request Feb 28, 2024
* collecting the RU information by pasing point through context.Value (tikv#1032)

Signed-off-by: zzm <zhouzemin@pingcap.com>

* add ruWaitDuration to RUDetails and update pd-client

Signed-off-by: glorv <glorvs@163.com>

---------

Signed-off-by: zzm <zhouzemin@pingcap.com>
Signed-off-by: glorv <glorvs@163.com>
Co-authored-by: zzm <zhouzemin@pingcap.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Signed-off-by: zzm <zhouzemin@pingcap.com>
zeminzhou added a commit to zeminzhou/client-go that referenced this pull request Mar 13, 2024
* collecting the RU information by pasing point through context.Value (tikv#1032)

Signed-off-by: zzm <zhouzemin@pingcap.com>

* add ruWaitDuration to RUDetails and update pd-client

Signed-off-by: glorv <glorvs@163.com>

---------

Signed-off-by: zzm <zhouzemin@pingcap.com>
Signed-off-by: glorv <glorvs@163.com>
Co-authored-by: zzm <zhouzemin@pingcap.com>
Signed-off-by: iosmanthus <myosmanthustree@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants