Skip to content

Redact the key value from error log#59

Merged
hanfei1991 merged 3 commits intotikv:masterfrom
JaySon-Huang:redact_log
Dec 24, 2020
Merged

Redact the key value from error log#59
hanfei1991 merged 3 commits intotikv:masterfrom
JaySon-Huang:redact_log

Conversation

@JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Dec 23, 2020

Log redacted: Avoid printing user data (mostly user keys) to info log. Replace the value with ?.

Signed-off-by: JaySon-Huang <tshent@qq.com>
@JaySon-Huang
Copy link
Contributor Author

/run-all-tests

Signed-off-by: JaySon-Huang <tshent@qq.com>
Signed-off-by: JaySon-Huang <tshent@qq.com>
Copy link
Member

@hanfei1991 hanfei1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanfei1991 hanfei1991 merged commit 62a4537 into tikv:master Dec 24, 2020
@JaySon-Huang JaySon-Huang deleted the redact_log branch December 24, 2020 05:16
hanfei1991 pushed a commit that referenced this pull request Dec 30, 2020
* Redact the key value

Signed-off-by: JaySon-Huang <tshent@qq.com>

* Fix build

Signed-off-by: JaySon-Huang <tshent@qq.com>

* Fix build

Signed-off-by: JaySon-Huang <tshent@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants