Merged
Conversation
Add gawk to the package runtime inputs so the script can resolve awk from its Nix closure. Also only emit ANSI formatting and cursor-control output when stdout is a terminal, which keeps non-interactive logs free of raw escape sequences. Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
kajusnau
approved these changes
Mar 13, 2026
brianmcgillion
approved these changes
Mar 15, 2026
henrirosten
added a commit
to tiiuae/ghaf-infra
that referenced
this pull request
Mar 16, 2026
Remove the temporary Jenkins-side gawk wrapper from delegated flashing now that tiiuae/ghaf#1823 fixed flash-script runtime inputs and non-interactive ANSI output upstream. Update the current-state flashing doc to record that the upstream follow-up landed and is no longer pending work for this branch. Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
henrirosten
added a commit
to tiiuae/ghaf-infra
that referenced
this pull request
Mar 16, 2026
Remove the temporary Jenkins-side gawk wrapper from delegated flashing now that tiiuae/ghaf#1823 fixed flash-script runtime inputs and non-interactive ANSI output upstream. Update the current-state flashing doc to record that the upstream follow-up landed and to drop stale remaining-work wording for issues already fixed in Ghaf. Signed-off-by: Henri Rosten <henri.rosten@unikie.com>
This was referenced Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add gawk to the flash-script package runtime inputs so the script can resolve awk (which it now depends on) from its Nix closure.
Also only emit ANSI formatting and cursor-control output when stdout is a terminal, which keeps non-interactive logs free of raw escape sequences.
Description of Changes
Type of Change
Related Issues / Tickets
Checklist
make-checksand it passesTesting Instructions
Applicable Targets
aarch64aarch64x86_64x86_64x86_64Installation Method
nixos-rebuild ... switchTest Steps To Verify: