Skip to content

fix: fix softlock on incorrect password#1633

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
kajusnau:login-softlock
Dec 12, 2025
Merged

fix: fix softlock on incorrect password#1633
brianmcgillion merged 1 commit intotiiuae:mainfrom
kajusnau:login-softlock

Conversation

@kajusnau
Copy link
Copy Markdown
Collaborator

@kajusnau kajusnau commented Dec 11, 2025 •
edited
Loading

Description of Changes

  1. Patched cosmic-greeter:

    • Added proper handling of auth_message of type error for greetd ipc (ref)
      These messages will be treated as errors.
    • Added proper handling of PAM conversation error messages.
      These messages will be treated as errors.
    • The above changes should prevent the system from getting softlocked in the "Authenticating..." state (https://jira.tii.ae/browse/SSRCSP-7679)

  2. Login-manager changes:

    • Disabled faillock PAM modules due to incompatibility with current login flow:
      During testing, I observed this scenario:
      • Input incorrect password - login is denied
      • Input incorrect password again - login is denied
      • Input correct password - homed accepts it internally, but faillock prevents login anyway
    • Added unixAuth option to control unixAuth in greetd and greeter:
      • Disabled by default
      • Enabled for Orins

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

https://jira.tii.ae/browse/SSRCSP-7679

Upstream PR - pop-os/cosmic-greeter#367

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

Verify https://jira.tii.ae/browse/SSRCSP-7679 is fixed (login and lockscreen should be tested separately)

@kajusnau kajusnau requested a review from gngram December 11, 2025 13:13
@kajusnau kajusnau self-assigned this Dec 11, 2025
@kajusnau kajusnau removed the request for review from gngram December 11, 2025 13:26
@kajusnau kajusnau marked this pull request as ready for review December 12, 2025 10:18
@kajusnau
fix: fix softlock on incorrect password
f0a8210 
- added patch to cosmic-greeter to handle pam auth_message errors
- patch fixes softlock on incorrect password in login and lockscreen
- disabled faillock pam modules due to incompatibility with current
  login flow
- disabled unixAuth by default
- enabled unixAuth for orins for autologin

Signed-off-by: Kajus Naujokaitis <kajus.naujokaitis@unikie.com>
@kajusnau kajusnau added the Needs Testing CI Team to pre-verify label Dec 12, 2025
vunnyso
vunnyso reviewed Dec 12, 2025
View reviewed changes
@milva-unikie
Copy link
Copy Markdown

milva-unikie commented Dec 12, 2025

Tested on Darter Pro and Lenovo X1 (nixos-rebuild switch)

  • Bug has been fixed.

Orin tests all passed in the jenkins-pre-merge, so I will assume everything is good there as well.

@milva-unikie milva-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on System76 and removed Needs Testing CI Team to pre-verify labels Dec 12, 2025
@kajusnau
Copy link
Copy Markdown
Collaborator Author

kajusnau commented Dec 12, 2025

Upstream PR - pop-os/cosmic-greeter#367

@brianmcgillion brianmcgillion merged commit 7cf5b1b into tiiuae:main Dec 12, 2025
32 checks passed
@kajusnau kajusnau mentioned this pull request Dec 12, 2025
Merged
19 tasks
@kajusnau kajusnau deleted the login-softlock branch December 12, 2025 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brianmcgillion brianmcgillion brianmcgillion approved these changes

@vunnyso vunnyso vunnyso approved these changes

@gngram gngram Awaiting requested review from gngram

Assignees

@kajusnau kajusnau

Labels

Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon Tested on System76

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kajusnau @milva-unikie @brianmcgillion @vunnyso