fix: improve error handling to prevent softlock#367
Merged
jacobgkau merged 1 commit intopop-os:masterfrom Dec 15, 2025
Merged
Conversation
- handle greetd ipc auth_message error types as errors - handle locker pam error_msg as errors - fixes an issue where greeter would get stuck in 'Authenticating...' state due to error messages being treated as normal messages
19 tasks
wash2
approved these changes
Dec 12, 2025
jacobgkau
approved these changes
Dec 15, 2025
Member
jacobgkau
left a comment
There was a problem hiding this comment.
Thank you for the fix. Login, the incorrect password message, and all of the buttons are working the same as before on Pop!_OS 24.04.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AuthMessageType::Errorare forwarded asMessage::Errorinstead ofMessage::Prompt.error_msgas errors viaerror_message, which are forwarded asMessage::Erroras well.Fixes an issue introduced by #349:
For example, when using systemd-homed, failed authentication would previously be treated as normal prompts, causing the greeter to softlock in the "Authenticating..." state, even though authentication has already failed.
This appears to happen due to pam_systemd_home sending
PAM_ERROR_MSGfollowed byPAM_PROMPT_ECHO_OFF, instead of the usualPAM_AUTH_ERRor similar.With this patch, PAM errors reset the "Authenticating..." state, and password input is re-enabled.