Skip to content

Fix ctrl-panel VM starting#1418

Merged
brianmcgillion merged 1 commit intotiiuae:mainfrom
slakkala:dev/ctrl-panel-vm-control
Sep 19, 2025
Merged

Fix ctrl-panel VM starting#1418
brianmcgillion merged 1 commit intotiiuae:mainfrom
slakkala:dev/ctrl-panel-vm-control

Conversation

@slakkala
Copy link
Copy Markdown
Contributor

@slakkala slakkala commented Sep 18, 2025

Description of Changes

Fix VM controls in ctrl-panel to allow starting a VM after it has been shut down.
Also fix issue, where VM/service controls became insensitive in some scenarios.

tiiuae/ghaf-givc#205
tiiuae/ghaf-ctrl-panel#104

Type of Change

  • New Feature
  • Bug Fix
  • Improvement / Refactor

Related Issues / Tickets

https://jira.tii.ae/browse/SSRCSP-7215

Checklist

  • Clear summary in PR description
  • Detailed and meaningful commit message(s)
  • Commits are logically organized and squashed if appropriate
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • Author has run make-checks and it passes
  • All automatic GitHub Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing Instructions

Applicable Targets

  • Orin AGX aarch64
  • Orin NX aarch64
  • Lenovo X1 x86_64
  • Dell Latitude x86_64
  • System 76 x86_64

Installation Method

  • Requires full re-installation
  • Can be updated with nixos-rebuild ... switch
  • Other:

Test Steps To Verify:

  1. open ghaf control panel
  2. choose an app vm from left hand side tree, for example chrome-vm
  3. choose stop from VM controls drop down
  4. wait for the status to update to "stopped"
  5. choose start from VM controls drop down
  6. wait for the status to update to "running"
  7. verify that app (for example, chrome) can be started from menu

Signed-off-by: Santtu Lakkala <santtu.lakkala@unikie.com>
@slakkala slakkala added the Needs Testing CI Team to pre-verify label Sep 18, 2025
@milva-unikie
Copy link
Copy Markdown

Tested on Lenovo-X1 (nixos-rebuild switch)

  • AppVMs can be shut down and restarted
  • VM status shows the current status in Control Panel
  • Apps work after VM has been restarted

Notes

  • Pause also works, but there is no way to unpause a VM. A separate issue can be raised for this.

@milva-unikie milva-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon and removed Needs Testing CI Team to pre-verify labels Sep 19, 2025
@slakkala
Copy link
Copy Markdown
Contributor Author

Pause also works, but there is no way to unpause a VM. A separate issue can be raised for this.

Let's go with separate issue.

@brianmcgillion brianmcgillion merged commit e79b91c into tiiuae:main Sep 19, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants