feature: allow shell & force enable adbd#3298
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds “rescue-mode” installation options to control whether shell is granted root by default and to force-enable ADB debugging via boot image patching / module parameters, with corresponding Manager UI toggles.
Changes:
- Add boot-patch CLI flags to inject ramdisk marker/prop files for allowing shell root and enabling ADB debug.
- Pass an
allow_shell=1module parameter fromksuinitbased on a ramdisk marker file. - Add KernelSU kernel-side
allow_shellmodule parameter and update allowlist behavior; add Manager UI strings and toggles.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
userspace/ksuinit/src/lib.rs |
Conditionally passes allow_shell=1 to init_module() when /ksu_allow_shell exists. |
userspace/ksud/src/boot_patch.rs |
Adds --allow-shell, --enable-adbd, and related options; writes marker/prop files into the ramdisk; adds --no-install. |
manager/app/src/main/res/values/strings.xml |
Adds English UI strings for the new install toggles. |
manager/app/src/main/res/values-zh-rCN/strings.xml |
Adds Simplified Chinese UI strings for the new install toggles. |
manager/app/src/main/java/me/weishu/kernelsu/ui/util/KsuCli.kt |
Appends --allow-shell / --enable-adbd flags to the boot-patch command. |
manager/app/src/main/java/me/weishu/kernelsu/ui/screen/install/InstallUiState.kt |
Extends install UI state/actions to include allow-shell and enable-adb selections. |
manager/app/src/main/java/me/weishu/kernelsu/ui/screen/install/InstallScreen.kt |
Adds persisted state + actions for allow-shell and enable-adb toggles. |
manager/app/src/main/java/me/weishu/kernelsu/ui/screen/install/InstallMiuix.kt |
Adds MIUIX checkboxes for the new toggles. |
manager/app/src/main/java/me/weishu/kernelsu/ui/screen/install/InstallMaterial.kt |
Adds Material segmented checkbox items for the new toggles. |
manager/app/src/main/java/me/weishu/kernelsu/ui/screen/flash/FlashUtils.kt |
Extends FlashIt.FlashBoot payload + installBoot() call to carry the new flags. |
kernel/ksu.c |
Introduces allow_shell module param and logs when enabled. |
kernel/allowlist.h |
Declares extern bool allow_shell; for allowlist usage. |
kernel/allowlist.c |
Allows shell UID based on allow_shell and adjusts root-profile selection for shell. |
Comments suppressed due to low confidence (1)
kernel/allowlist.h:58
- The
extern bool allow_shell;declaration is placed after the header guard’s closing#endif, so it is not protected by the include guard and will be re-declared on every include. Move thisexterninside the guard (before the final#endif) to keep the header well-formed and avoid accidental duplication.
#endif
extern bool allow_shell;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
YuKongA
approved these changes
Mar 16, 2026
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 16, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 16, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
KOWX712
added a commit
to KOWX712/KernelSU
that referenced
this pull request
Mar 16, 2026
Co-Authored-By: KOWX712 <leecc0503@gmail.com> Co-Authored-By: YuKongA <70465933+YuKongA@users.noreply.github.com>
aviraxp
pushed a commit
that referenced
this pull request
Mar 16, 2026
Co-authored-by: KOWX712 <leecc0503@gmail.com> Co-authored-by: YuKongA <70465933+YuKongA@users.noreply.github.com>
selfmusing
pushed a commit
to selfmusing/USlenreK
that referenced
this pull request
Mar 16, 2026
Co-authored-by: KOWX712 <leecc0503@gmail.com> Co-authored-by: YuKongA <70465933+YuKongA@users.noreply.github.com>
selfmusing
pushed a commit
to selfmusing/USlenreK
that referenced
this pull request
Mar 16, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 17, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 17, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 17, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 17, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 17, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 20, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 20, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 20, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 20, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 20, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 20, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 20, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 20, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 20, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 20, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 20, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 20, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 20, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 20, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 20, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 20, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 20, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 20, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 20, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 20, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 20, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
selfmusing
pushed a commit
to selfmusing/USlenreK
that referenced
this pull request
Mar 20, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 21, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 21, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 21, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 21, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 21, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
selfmusing
pushed a commit
to selfmusing/USlenreK
that referenced
this pull request
Mar 21, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
backslashxx
added a commit
to backslashxx/KernelSU
that referenced
this pull request
Mar 22, 2026
upstream: tiann@5dddcbe tiann#3298 we skip module param for this one, it does not make sense for built-in. Signed-off-by: backslashxx <118538522+backslashxx@users.noreply.github.com>
|
The variable used in kernel space |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.