Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates CI to build ksud for Android using the NDK toolchain directly (without cross), while keeping a separate reusable workflow for cross-based builds of non-Android targets.
Changes:
- Switch
.github/workflows/ksud.ymlfromcross buildtocargo buildwith NDK-provided clang/linker env wiring. - Expand the example Cargo config to include both
aarch64-linux-androidandx86_64-linux-androidtoolchain placeholders/env. - Add
ksud-extra.ymlreusable workflow (cross-based) and updatebuild-manager.ymlto use it for “extra” targets.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
userspace/ksud/.cargo/config.example.toml |
Adds separate placeholder toolchain vars and cargo target sections for Android aarch64 + x86_64. |
.github/workflows/ksud.yml |
Builds Android targets without cross by configuring NDK clang/ar + Cargo linker env vars. |
.github/workflows/ksud-extra.yml |
New reusable workflow to build ksud with cross for non-Android targets. |
.github/workflows/build-manager.yml |
Routes extra targets to the new ksud-extra.yml and enables packing inputs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
585ed1f to
70542f4
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Tools-cx-app
pushed a commit
to ReSukiSU/ReSukiSU
that referenced
this pull request
Mar 28, 2026
…iann/KernelSU#3251) [cherry-pick tiann/KernelSU#3251] Signed-off-by: Tools-cx-app <localhost.hutao@gmail.com>
Tools-cx-app
pushed a commit
to ReSukiSU/ReSukiSU
that referenced
this pull request
Mar 28, 2026
…iann/KernelSU#3251) [cherry-pick tiann/KernelSU#3251] Signed-off-by: Tools-cx-app <localhost.hutao@gmail.com>
Tools-cx-app
pushed a commit
to ReSukiSU/ReSukiSU
that referenced
this pull request
Mar 28, 2026
…iann/KernelSU#3251) [cherry-pick tiann/KernelSU#3251] Signed-off-by: Tools-cx-app <localhost.hutao@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.