manager: cleanup Downloader and fix warnings#3229
Merged
Merged
Conversation
- Remove unused `DownloadListener` Composable from `Downloader.kt` and its usages in `ModuleRepo.kt` and `Module.kt`. - Use `LocalResources.current` instead of `context.getString` in `SendLogDialog.kt`. - Rename `it` parameter to `activityResult` in `Module.kt` for better clarity. - Remove unused `onInstallModule` parameter and callback in `ModuleScreen`. Signed-off-by: u9521 <63995396+u9521@users.noreply.github.com>
u9521
added a commit
to u9521/KernelSU
that referenced
this pull request
Feb 26, 2026
commit (b3d5820) refactored the download logic to use OkHttp downloader instead of the system's DownloadManager. However, the DownloadListener was designed to listen for DownloadManager's broadcasts, was inadvertently left behind. Signed-off-by: u9521 <63995396+u9521@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit (b3d5820) refactored the download logic to use OkHttp downloader instead of the system's DownloadManager. However, the DownloadListener was designed to listen for DownloadManager's broadcasts, was inadvertently left behind.