manager(refactor): change kernel umount to a switch preference, figure the sucompte string problem#3146
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the kernel umount setting from a dropdown (SuperDropdown) to a switch (SuperSwitch) for better user experience, and updates string resources to improve clarity by renaming "sucompte" to "sucompat" and revising related text across all language files.
Changes:
- Changed kernel umount UI from SuperDropdown with three modes to SuperSwitch with simple on/off toggle
- Renamed string resources from "settings_disable_su" to "settings_sucompat" and "settings_disable_kernel_umount" to "settings_kernel_umount" for better clarity
- Added new string resources for mode options and updated translations across 40+ language files
Reviewed changes
Copilot reviewed 45 out of 45 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| manager/app/src/main/java/me/weishu/kernelsu/ui/screen/Settings.kt | Refactored kernel umount from dropdown to switch, simplified state management, updated string resource references |
| manager/app/src/main/res/values/strings.xml | Updated English string resources with clearer naming (sucompat instead of disable_su, kernel_umount instead of disable_kernel_umount) |
| manager/app/src/main/res/values-*/strings.xml | Applied consistent string updates across all 40+ localization files |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
应该是：允许应用通过执行 /system/bin/su 获取超级用户 shell |
5ec1cff
reviewed
Jan 12, 2026
e1032c9 to
d7cd85f
Compare
…e the sucompat string problem Co-authored-by: Weblate (bot) <hosted@weblate.org> Co-authored-by: yuztass <inkognito0901@gmail.com> Co-authored-by: Beni Fachrudin <neebexd@gmail.com> Co-authored-by: dabao1955 <dabao1955@163.com> Co-authored-by: Léane GRASSER <leane.grasser@proton.me> Co-authored-by: SchweGELBin <abramjannikmichael06@gmail.com> Co-authored-by: searinminecraft <kitakita@disroot.org>
5ec1cff
approved these changes
Jan 16, 2026
YuKongA
approved these changes
Jan 18, 2026
KOWX712
pushed a commit
to KOWX712/KernelSU
that referenced
this pull request
Jan 18, 2026
…e the sucompte string problem (tiann#3146) - Update `Settings.kt` to use `SuperSwitch` instead of `SuperDropdown` for the kernel umount setting. - Change the string of sucompte to prevent misunderstanding. --------- Co-authored-by: Weblate (bot) <hosted@weblate.org> Co-authored-by: yuztass <inkognito0901@gmail.com> Co-authored-by: Beni Fachrudin <neebexd@gmail.com> Co-authored-by: dabao1955 <dabao1955@163.com> Co-authored-by: Léane GRASSER <leane.grasser@proton.me> Co-authored-by: SchweGELBin <abramjannikmichael06@gmail.com> Co-authored-by: searinminecraft <kitakita@disroot.org> Co-authored-by: YuKongA <70465933+YuKongA@users.noreply.github.com>
u9521
added a commit
to u9521/KernelSU
that referenced
this pull request
Jan 20, 2026
…e the sucompte string problem (tiann#3146) - Update `Settings.kt` to use `SuperSwitch` instead of `SuperDropdown` for the kernel umount setting. - Change the string of sucompte to prevent misunderstanding. --------- Co-authored-by: Weblate (bot) <hosted@weblate.org> Co-authored-by: yuztass <inkognito0901@gmail.com> Co-authored-by: Beni Fachrudin <neebexd@gmail.com> Co-authored-by: dabao1955 <dabao1955@163.com> Co-authored-by: Léane GRASSER <leane.grasser@proton.me> Co-authored-by: SchweGELBin <abramjannikmichael06@gmail.com> Co-authored-by: searinminecraft <kitakita@disroot.org> Co-authored-by: YuKongA <70465933+YuKongA@users.noreply.github.com> Co-authored-by: 米凛MiRin <148533509+mirinchan@users.noreply.github.com> Signed-off-by: u9521 <63995396+u9521@users.noreply.github.com>
u9521
added a commit
to u9521/KernelSU
that referenced
this pull request
Jan 20, 2026
…e the sucompte string problem (tiann#3146) - Update `Settings.kt` to use `SuperSwitch` instead of `SuperDropdown` for the kernel umount setting. - Change the string of sucompte to prevent misunderstanding. --------- Co-authored-by: Weblate (bot) <hosted@weblate.org> Co-authored-by: yuztass <inkognito0901@gmail.com> Co-authored-by: Beni Fachrudin <neebexd@gmail.com> Co-authored-by: dabao1955 <dabao1955@163.com> Co-authored-by: Léane GRASSER <leane.grasser@proton.me> Co-authored-by: SchweGELBin <abramjannikmichael06@gmail.com> Co-authored-by: searinminecraft <kitakita@disroot.org> Co-authored-by: YuKongA <70465933+YuKongA@users.noreply.github.com> Co-authored-by: 米凛MiRin <148533509+mirinchan@users.noreply.github.com> Signed-off-by: u9521 <63995396+u9521@users.noreply.github.com>
u9521
added a commit
to u9521/KernelSU
that referenced
this pull request
Jan 20, 2026
…e the sucompte string problem (tiann#3146) - Update `Settings.kt` to use `SuperSwitch` instead of `SuperDropdown` for the kernel umount setting. - Change the string of sucompte to prevent misunderstanding. --------- Co-authored-by: Weblate (bot) <hosted@weblate.org> Co-authored-by: yuztass <inkognito0901@gmail.com> Co-authored-by: Beni Fachrudin <neebexd@gmail.com> Co-authored-by: dabao1955 <dabao1955@163.com> Co-authored-by: Léane GRASSER <leane.grasser@proton.me> Co-authored-by: SchweGELBin <abramjannikmichael06@gmail.com> Co-authored-by: searinminecraft <kitakita@disroot.org> Co-authored-by: YuKongA <70465933+YuKongA@users.noreply.github.com> Co-authored-by: 米凛MiRin <148533509+mirinchan@users.noreply.github.com> Signed-off-by: u9521 <63995396+u9521@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings.ktto useSuperSwitchinstead ofSuperDropdownfor the kernel umount setting.Known issue:
By long string, line brake looks broken on options. This issue is may caused by miuix.