manager: fix all warnings#3098
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses compiler warnings in the manager module by fixing string formatting issues and updating deprecated APIs.
Key changes:
- Updated string format specifiers from simple
%dto positional%1$dand%2$dfor proper parameter ordering in localized strings - Migrated from deprecated
LocalClipboardManagerto the newLocalClipboardAPI in Compose - Removed the deprecated
Shell.FLAG_REDIRECT_STDERRflag
Reviewed changes
Copilot reviewed 39 out of 39 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| manager/app/src/main/res/values/strings.xml | Fixed format specifiers for require_kernel_version string |
| manager/app/src/main/res/values-zh-rTW/strings.xml | Fixed format specifiers in Traditional Chinese translation |
| manager/app/src/main/res/values-zh-rHK/strings.xml | Fixed format specifiers in Hong Kong Chinese translation |
| manager/app/src/main/res/values-zh-rCN/strings.xml | Fixed format specifiers in Simplified Chinese translation |
| manager/app/src/main/res/values-vi/strings.xml | Fixed format specifiers in Vietnamese translation |
| manager/app/src/main/res/values-uk/strings.xml | Fixed format specifiers in Ukrainian translation |
| manager/app/src/main/res/values-tr/strings.xml | Fixed format specifiers in Turkish translation |
| manager/app/src/main/res/values-th/strings.xml | Fixed format specifiers in Thai translation |
| manager/app/src/main/res/values-sl/strings.xml | Fixed format specifiers in Slovenian translation |
| manager/app/src/main/res/values-ru/strings.xml | Fixed format specifiers in Russian translation |
| manager/app/src/main/res/values-ro/strings.xml | Fixed format specifiers in Romanian translation |
| manager/app/src/main/res/values-pt/strings.xml | Fixed format specifiers in Portuguese translation |
| manager/app/src/main/res/values-pt-rBR/strings.xml | Fixed format specifiers in Brazilian Portuguese translation |
| manager/app/src/main/res/values-pl/strings.xml | Fixed format specifiers in Polish translation |
| manager/app/src/main/res/values-nl/strings.xml | Fixed format specifiers in Dutch translation |
| manager/app/src/main/res/values-lv/strings.xml | Fixed format specifiers in Latvian translation |
| manager/app/src/main/res/values-lt/strings.xml | Fixed format specifiers in Lithuanian translation |
| manager/app/src/main/res/values-ko/strings.xml | Fixed format specifiers in Korean translation |
| manager/app/src/main/res/values-kn/strings.xml | Fixed format specifiers in Kannada translation |
| manager/app/src/main/res/values-ja/strings.xml | Fixed format specifiers in Japanese translation |
| manager/app/src/main/res/values-iw/strings.xml | Fixed format specifiers in Hebrew translation |
| manager/app/src/main/res/values-it/strings.xml | Fixed format specifiers in Italian translation |
| manager/app/src/main/res/values-in/strings.xml | Fixed format specifiers in Indonesian translation |
| manager/app/src/main/res/values-hu/strings.xml | Fixed format specifiers in Hungarian translation |
| manager/app/src/main/res/values-hr/strings.xml | Fixed format specifiers in Croatian translation |
| manager/app/src/main/res/values-hi/strings.xml | Fixed format specifiers in Hindi translation |
| manager/app/src/main/res/values-fr/strings.xml | Fixed format specifiers in French translation |
| manager/app/src/main/res/values-fil/strings.xml | Fixed format specifiers in Filipino translation |
| manager/app/src/main/res/values-et/strings.xml | Fixed format specifiers in Estonian translation |
| manager/app/src/main/res/values-es/strings.xml | Fixed format specifiers in Spanish translation |
| manager/app/src/main/res/values-de/strings.xml | Fixed format specifiers in German translation |
| manager/app/src/main/res/values-da/strings.xml | Fixed format specifiers in Danish translation |
| manager/app/src/main/res/values-bs/strings.xml | Fixed format specifiers in Bosnian translation |
| manager/app/src/main/res/values-bn/strings.xml | Fixed format specifiers in Bengali translation |
| manager/app/src/main/res/values-bg/strings.xml | Fixed format specifiers in Bulgarian translation |
| manager/app/src/main/res/values-az/strings.xml | Fixed format specifiers in Azerbaijani translation |
| manager/app/src/main/res/values-ar/strings.xml | Fixed format specifiers in Arabic translation |
| manager/app/src/main/java/me/weishu/kernelsu/ui/util/SELinuxChecker.kt | Removed deprecated Shell.FLAG_REDIRECT_STDERR flag |
| manager/app/src/main/java/me/weishu/kernelsu/ui/screen/Template.kt | Migrated clipboard operations from deprecated LocalClipboardManager to LocalClipboard API |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…e.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…e.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 39 out of 39 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
manager/app/src/main/java/me/weishu/kernelsu/ui/screen/Template.kt:203
- The coroutine scope wrapping has been changed. In the original code, the clipboard was read synchronously and only the import operation was wrapped in a coroutine. Now the clipboard read is also inside the coroutine. The clipboard getClipEntry call should be synchronous and doesn't need to be inside scope.launch. Consider moving scope.launch to only wrap the viewModel.importTemplates call to maintain the original behavior.
scope.launch {
clipboard.getClipEntry()?.clipData?.getItemAt(0)?.text?.toString()?.let {
if (it.isEmpty()) {
showToast(context.getString(R.string.app_profile_template_import_empty))
return@let
}
viewModel.importTemplates(
it, {
showToast(context.getString(R.string.app_profile_template_import_success))
viewModel.fetchTemplates(false)
},
showToast
)
}
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
YuKongA
approved these changes
Dec 23, 2025
bklynali
pushed a commit
to bklynali/BK-KSU
that referenced
this pull request
Dec 23, 2025
Some changes made by AI, so please review, edits welcomed. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Wang Han <416810799@qq.com> Co-authored-by: YuKongA <70465933+YuKongA@users.noreply.github.com>
KOWX712
pushed a commit
to KOWX712/KernelSU
that referenced
this pull request
Dec 23, 2025
Some changes made by AI, so please review, edits welcomed. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Wang Han <416810799@qq.com> Co-authored-by: YuKongA <70465933+YuKongA@users.noreply.github.com>
u9521
added a commit
to u9521/KernelSU
that referenced
this pull request
Jan 5, 2026
Some changes made by AI, so please review, edits welcomed. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Wang Han <416810799@qq.com> Co-authored-by: YuKongA <70465933+YuKongA@users.noreply.github.com> Co-authored-by: Caner Karaca <37447503+canerkaraca23@users.noreply.github.com> Signed-off-by: u9521 <63995396+u9521@users.noreply.github.com>
u9521
added a commit
to u9521/KernelSU
that referenced
this pull request
Jan 5, 2026
Some changes made by AI, so please review, edits welcomed. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Wang Han <416810799@qq.com> Co-authored-by: YuKongA <70465933+YuKongA@users.noreply.github.com> Co-authored-by: Caner Karaca <37447503+canerkaraca23@users.noreply.github.com> Signed-off-by: u9521 <63995396+u9521@users.noreply.github.com>
u9521
added a commit
to u9521/KernelSU
that referenced
this pull request
Jan 8, 2026
Some changes made by AI, so please review, edits welcomed. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Wang Han <416810799@qq.com> Co-authored-by: YuKongA <70465933+YuKongA@users.noreply.github.com> Co-authored-by: Caner Karaca <37447503+canerkaraca23@users.noreply.github.com> Signed-off-by: u9521 <63995396+u9521@users.noreply.github.com>
u9521
added a commit
to u9521/KernelSU
that referenced
this pull request
Jan 13, 2026
Some changes made by AI, so please review, edits welcomed. --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Wang Han <416810799@qq.com> Co-authored-by: YuKongA <70465933+YuKongA@users.noreply.github.com> Co-authored-by: Caner Karaca <37447503+canerkaraca23@users.noreply.github.com> Signed-off-by: u9521 <63995396+u9521@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some changes made by AI, so please review, edits welcomed.