kernel: use rcu to access allowlist, refactor get allowlist api#3093
Merged
Conversation
3 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the allow list API to optimize how the superuser count is retrieved. Instead of fetching the entire list of UIDs just to get the count, it introduces a dedicated getSuperuserCount() method that only returns the count. The API changes also introduce a more flexible allow list structure with support for paginated retrieval.
Key changes:
- Replaced direct
allowList.sizeaccess with a newgetSuperuserCount()native method - Refactored the kernel
ksu_get_allow_list_cmdstructure to use a flexible array member and separate count fields - Unified allow/deny list retrieval logic into a common
do_get_list_commonfunction with proper memory management
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| manager/app/src/main/java/me/weishu/kernelsu/ui/util/KsuCli.kt | Updated to call the new getSuperuserCount() method instead of accessing allowList.size |
| manager/app/src/main/java/me/weishu/kernelsu/Natives.kt | Removed the allowList property and added getSuperuserCount() external function |
| manager/app/src/main/cpp/ksu.h | Modified ksu_get_allow_list_cmd structure to use flexible array member and split count fields |
| manager/app/src/main/cpp/jni.cc | Replaced getAllowList() with getSuperuserCount() that only retrieves the total count |
| kernel/supercalls.h | Updated ksu_get_allow_list_cmd structure to match the userspace changes |
| kernel/supercalls.c | Refactored allow/deny list retrieval into common function with dynamic memory allocation |
| kernel/allowlist.h | Updated function signature to accept separate length and total count parameters |
| kernel/allowlist.c | Modified implementation to track both returned items and total count separately |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
991087e to
55f0d69
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 10 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ef91a7d to
8fc71fe
Compare
8fc71fe to
60e79e7
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0d2c087 to
a4df977
Compare
AlexLiuDev233
pushed a commit
to ReSukiSU/ReSukiSU
that referenced
this pull request
Feb 24, 2026
…n/KernelSU#3093) [cherry-picked from upstream commit: tiann/KernelSU@9f68f23] Signed-off-by: AlexLiuDev233 <wzylin11@outlook.com>
AlexLiuDev233
pushed a commit
to ReSukiSU/ReSukiSU
that referenced
this pull request
Feb 24, 2026
…n/KernelSU#3093) [cherry-picked from upstream commit: tiann/KernelSU@9f68f23] Signed-off-by: AlexLiuDev233 <wzylin11@outlook.com>
AlexLiuDev233
pushed a commit
to ReSukiSU/ReSukiSU
that referenced
this pull request
Feb 24, 2026
…n/KernelSU#3093) [cherry-picked from upstream commit: tiann/KernelSU@9f68f23] Signed-off-by: AlexLiuDev233 <wzylin11@outlook.com>
AlexLiuDev233
pushed a commit
to ReSukiSU/ReSukiSU
that referenced
this pull request
Feb 24, 2026
…n/KernelSU#3093) [cherry-picked from upstream commit: tiann/KernelSU@9f68f23] Signed-off-by: AlexLiuDev233 <wzylin11@outlook.com>
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Feb 24, 2026
Anatdx
added a commit
to Anatdx/YukiSU
that referenced
this pull request
Feb 25, 2026
…lSU #3093) Port upstream KernelSU PR #3093 to fix GET_ALLOW_LIST buffer overflow (#3086) and align with the new allowlist API. Kernel (YukiSU): - allowlist: ksu_get_allow_list(array, length, out_length, out_total, allow) with RCU read lock and list_for_each_entry_rcu; exclude manager UID from returned list; perm_data gains rcu_head, list_add_tail_rcu / list_del_rcu / kfree_rcu for writers. - supercalls: add ksu_new_get_allow_list_cmd (count, total_count, uids[]), do_get_allow_list_common (kmalloc 128, copy_to_user) for old IOCTL, do_new_get_allow_list_common for new IOCTL; register NEW_GET_ALLOW_LIST / NEW_GET_DENY_LIST. Manager: - ksu.h/c: struct ksu_new_get_allow_list_cmd, get_superuser_count() using NEW_GET_ALLOW_LIST with count=0; keep get_allow_list for old API. - jni: getSuperuserCount() native; Natives.kt getSuperuserCount(); KsuCli uses getSuperuserCount() instead of allowList.size. HymoFS (sync): - Prefer ksu_get_allow_list() via kallsyms when available; fallback to reading /data/adb/ksu/.allowlist unchanged. Ref: tiann/KernelSU#3093 Cherry-picked from upstream: tiann/KernelSU@9f68f23 Co-authored-by: 5ec1cff <56485584+5ec1cff@users.noreply.github.com>
linastorvaldz
pushed a commit
to linastorvaldz/VortexSU
that referenced
this pull request
Mar 11, 2026
…n/KernelSU#3093) [cherry-picked from upstream commit: tiann/KernelSU@9f68f23] Signed-off-by: AlexLiuDev233 <wzylin11@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.