ksuinit: update dependencies and migrate to 2024#3088
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the ksuinit userspace component to Rust edition 2024, updates the syscalls dependency from version 0.6 to 0.7, and applies the new #[unsafe(no_mangle)] attribute syntax required by Rust 2024. The changes also include stylistic import reordering to follow alphabetical conventions.
- Updates Rust edition from 2021 to 2024
- Migrates
#[no_mangle]to#[unsafe(no_mangle)]syntax for Rust 2024 - Updates
syscallsdependency from 0.6.15 to 0.7.0
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| userspace/ksuinit/src/main.rs | Updates #[no_mangle] to #[unsafe(no_mangle)] attribute syntax required by Rust 2024 edition |
| userspace/ksuinit/src/loader.rs | Reorders imports alphabetically (style-only change) |
| userspace/ksuinit/src/init.rs | Reorders imports alphabetically (style-only change) |
| userspace/ksuinit/Cargo.toml | Updates edition to 2024 and syscalls dependency to 0.7 |
| userspace/ksuinit/Cargo.lock | Updates all transitive dependencies to their latest versions |
Comments suppressed due to low confidence (1)
userspace/ksuinit/src/main.rs:17
- The
unsafeblock on line 15 is redundant. Since themainfunction is already declared asunsafe extern "C"on line 13, the entire function body is already in an unsafe context. The innerunsafeblock can be removed and theexecvecall can be made directly.
unsafe {
execve(cstr!("/init"), argv, envp);
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
goblin and kernlog can be updated to use upstream version. (kernlog needs to manually point to kstep/kernlog.rs@ff0b1bd) |
Merged
yujincheng08
pushed a commit
that referenced
this pull request
Dec 23, 2025
#3088 (comment) https://github.com/Kernel-SU/rustix can be upstreamed for update.
luyanci
pushed a commit
to ReSukiSU/ReSukiSU
that referenced
this pull request
Dec 23, 2025
tiann/KernelSU#3088 (comment) https://github.com/Kernel-SU/rustix can be upstreamed for update.
bklynali
pushed a commit
to bklynali/BK-KSU
that referenced
this pull request
Dec 23, 2025
`goblin` version is too old, i recommend to upstream it since it's fork. because of it, `scroll` cannot be updated. Edits welcomed.
bklynali
pushed a commit
to bklynali/BK-KSU
that referenced
this pull request
Dec 23, 2025
tiann#3088 (comment) https://github.com/Kernel-SU/rustix can be upstreamed for update.
KOWX712
pushed a commit
to KOWX712/KernelSU
that referenced
this pull request
Dec 23, 2025
`goblin` version is too old, i recommend to upstream it since it's fork. because of it, `scroll` cannot be updated. Edits welcomed.
KOWX712
pushed a commit
to KOWX712/KernelSU
that referenced
this pull request
Dec 23, 2025
tiann#3088 (comment) https://github.com/Kernel-SU/rustix can be upstreamed for update.
ShirkNeko
pushed a commit
to SukiSU-Ultra/SukiSU-Ultra
that referenced
this pull request
Dec 25, 2025
tiann/KernelSU#3088 (comment) https://github.com/Kernel-SU/rustix can be upstreamed for update.
ShirkNeko
pushed a commit
to SukiSU-Ultra/SukiSU-Ultra
that referenced
this pull request
Dec 25, 2025
tiann/KernelSU#3088 (comment) https://github.com/Kernel-SU/rustix can be upstreamed for update.
luyanci
pushed a commit
to ReSukiSU/ReSukiSU
that referenced
this pull request
Dec 26, 2025
tiann/KernelSU#3088 (comment) https://github.com/Kernel-SU/rustix can be upstreamed for update.
rifsxd
pushed a commit
to KernelSU-Next/KernelSU-Next
that referenced
this pull request
Dec 28, 2025
tiann/KernelSU#3088 (comment) https://github.com/Kernel-SU/rustix can be upstreamed for update.
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 5, 2026
`goblin` version is too old, i recommend to upstream it since it's fork. because of it, `scroll` cannot be updated. Edits welcomed.
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 5, 2026
tiann#3088 (comment) https://github.com/Kernel-SU/rustix can be upstreamed for update.
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 5, 2026
`goblin` version is too old, i recommend to upstream it since it's fork. because of it, `scroll` cannot be updated. Edits welcomed.
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 5, 2026
tiann#3088 (comment) https://github.com/Kernel-SU/rustix can be upstreamed for update.
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 8, 2026
`goblin` version is too old, i recommend to upstream it since it's fork. because of it, `scroll` cannot be updated. Edits welcomed.
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 8, 2026
tiann#3088 (comment) https://github.com/Kernel-SU/rustix can be upstreamed for update.
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 13, 2026
`goblin` version is too old, i recommend to upstream it since it's fork. because of it, `scroll` cannot be updated. Edits welcomed.
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 13, 2026
tiann#3088 (comment) https://github.com/Kernel-SU/rustix can be upstreamed for update.
LeCmnGend
pushed a commit
to LeCmnGend/KernelSU
that referenced
this pull request
Feb 23, 2026
`goblin` version is too old, i recommend to upstream it since it's fork. because of it, `scroll` cannot be updated. Edits welcomed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
goblinversion is too old, i recommend to upstream it since it's fork.because of it,
scrollcannot be updated.Edits welcomed.