manager: Prevent module installation via external sources in safe mode#3079
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent module installation via external sources (e.g., file managers) when KernelSU is in safe mode, adding a safety mechanism to protect the system.
- Added localized string resources for safe mode module installation warning (English and Chinese)
- Modified ZIP file intent handler to check for safe mode and display appropriate warning dialog
- Attempted to override dialog behavior to prevent installation in safe mode
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| manager/app/src/main/res/values/strings.xml | Added English string resource for safe mode module installation disabled message |
| manager/app/src/main/res/values-zh-rCN/strings.xml | Added Chinese translation for safe mode module installation disabled message |
| manager/app/src/main/java/me/weishu/kernelsu/ui/MainActivity.kt | Added safe mode check in ZIP file intent handler to prevent module installation, but contains a critical implementation bug |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0f6b595 to
14abd40
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Replaced safe mode dialog with a Toast message for warnings.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
KOWX712
pushed a commit
to KOWX712/KernelSU
that referenced
this pull request
Dec 21, 2025
tiann#3079) Signed-off-by: sakana164 <76257039+sakana164@users.noreply.github.com> --------- Co-authored-by: Wang Han <416810799@qq.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
rsuntk
pushed a commit
to rsuntk/KernelSU
that referenced
this pull request
Dec 21, 2025
tiann#3079) Signed-off-by: sakana164 <76257039+sakana164@users.noreply.github.com> --------- Co-authored-by: Wang Han <416810799@qq.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bklynali
pushed a commit
to bklynali/BK-KSU
that referenced
this pull request
Dec 23, 2025
tiann#3079) Signed-off-by: sakana164 <76257039+sakana164@users.noreply.github.com> --------- Co-authored-by: Wang Han <416810799@qq.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 5, 2026
tiann#3079) Signed-off-by: sakana164 <76257039+sakana164@users.noreply.github.com> --------- Co-authored-by: Wang Han <416810799@qq.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 5, 2026
tiann#3079) Signed-off-by: sakana164 <76257039+sakana164@users.noreply.github.com> --------- Co-authored-by: Wang Han <416810799@qq.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 8, 2026
tiann#3079) Signed-off-by: sakana164 <76257039+sakana164@users.noreply.github.com> --------- Co-authored-by: Wang Han <416810799@qq.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 13, 2026
tiann#3079) Signed-off-by: sakana164 <76257039+sakana164@users.noreply.github.com> --------- Co-authored-by: Wang Han <416810799@qq.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sakana164 76257039+sakana164@users.noreply.github.com