manager: Refactor Markdown composable to use FrameLayout#3059
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Markdown and GithubMarkdown components to wrap their views (ScrollView and WebView respectively) in a FrameLayout container and use tag-based view lookup for safer updates.
Key Changes
- Wraps existing views in FrameLayout containers for both Markdown and GithubMarkdown components
- Implements tag-based view lookup using
findViewWithTag()for safer view references in update blocks - Removes an unnecessary
returnkeyword in GithubMarkdown error handling
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| manager/app/src/main/java/me/weishu/kernelsu/ui/component/Markdown.kt | Wraps TextView/ScrollView in FrameLayout, adds tag-based lookup in update block, but incorrectly removes required toArgb import |
| manager/app/src/main/java/me/weishu/kernelsu/ui/component/GithubMarkdown.kt | Wraps WebView in FrameLayout with tag assignment, cleans up return statement in error handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
KOWX712
pushed a commit
to KOWX712/KernelSU
that referenced
this pull request
Dec 9, 2025
rsuntk
pushed a commit
to rsuntk/KernelSU
that referenced
this pull request
Dec 11, 2025
https://wbrawner.com/2024/08/28/android-webview-crash-in-jetpack-compose/ Signed-off-by: rsuntk <rissu.ntk@gmail.com>
selfmusing
pushed a commit
to selfmusing/USlenreK
that referenced
this pull request
Dec 11, 2025
larpedd
pushed a commit
to larpedd/KernelSU
that referenced
this pull request
Dec 20, 2025
u9521
added a commit
to u9521/KernelSU
that referenced
this pull request
Jan 5, 2026
https://wbrawner.com/2024/08/28/android-webview-crash-in-jetpack-compose/ Co-authored-by: Wang Han <416810799@qq.com> Signed-off-by: u9521 <63995396+u9521@users.noreply.github.com>
u9521
added a commit
to u9521/KernelSU
that referenced
this pull request
Jan 5, 2026
https://wbrawner.com/2024/08/28/android-webview-crash-in-jetpack-compose/ Co-authored-by: Wang Han <416810799@qq.com> Signed-off-by: u9521 <63995396+u9521@users.noreply.github.com>
u9521
added a commit
to u9521/KernelSU
that referenced
this pull request
Jan 8, 2026
https://wbrawner.com/2024/08/28/android-webview-crash-in-jetpack-compose/ Co-authored-by: Wang Han <416810799@qq.com> Signed-off-by: u9521 <63995396+u9521@users.noreply.github.com>
u9521
added a commit
to u9521/KernelSU
that referenced
this pull request
Jan 13, 2026
https://wbrawner.com/2024/08/28/android-webview-crash-in-jetpack-compose/ Co-authored-by: Wang Han <416810799@qq.com> Signed-off-by: u9521 <63995396+u9521@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wbrawner.com/2024/08/28/android-webview-crash-in-jetpack-compose/