kernel: Install manager fd in task work#3057
Merged
Merged
Conversation
Tracepoint context disables preemption, so we cannot install fd which can sleep. Let manager use ioctl to install fd itself.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a critical concurrency issue by removing fd installation from a tracepoint context where preemption is disabled. The manager will now use ioctl to install the fd itself, avoiding potential sleeping in atomic context.
- Removed
ksu_install_fd()call fromksu_handle_setresuid()function - Updated log message to reflect that the code now handles manager start without fd installation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
KOWX712
pushed a commit
to KOWX712/KernelSU
that referenced
this pull request
Dec 9, 2025
Tracepoint context disables preemption, so we cannot install fd which can sleep.
selfmusing
pushed a commit
to selfmusing/USlenreK
that referenced
this pull request
Dec 11, 2025
Tracepoint context disables preemption, so we cannot install fd which can sleep.
larpedd
pushed a commit
to larpedd/KernelSU
that referenced
this pull request
Dec 20, 2025
Tracepoint context disables preemption, so we cannot install fd which can sleep.
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 5, 2026
Tracepoint context disables preemption, so we cannot install fd which can sleep.
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 5, 2026
Tracepoint context disables preemption, so we cannot install fd which can sleep.
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 8, 2026
Tracepoint context disables preemption, so we cannot install fd which can sleep.
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 13, 2026
Tracepoint context disables preemption, so we cannot install fd which can sleep.
LeCmnGend
pushed a commit
to LeCmnGend/KernelSU
that referenced
this pull request
Feb 23, 2026
Tracepoint context disables preemption, so we cannot install fd which can sleep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracepoint context disables preemption, so we cannot install fd which can sleep.