Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors manager UID handling to identify the manager by normalized app ID (appid) rather than the full UID, since appid is consistent across all user profiles for a given package. The key change is that ksu_get_manager_uid() now returns the normalized appid instead of a potentially profile-specific full UID.
- Manager UID is now stored and compared as normalized appid (uid % PER_USER_RANGE)
- Replaces hardcoded
100000magic number withPER_USER_RANGEconstant - Removes special handling for private space UIDs in setuid hook
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| kernel/manager.h | Added allowlist.h include for PER_USER_RANGE; modified is_manager() and ksu_set_manager_uid() to normalize UIDs with modulo operation |
| kernel/setuid_hook.c | Removed private space UID handling; simplified manager UID comparison by normalizing new_uid |
| kernel/throne_tracker.c | Replaced hardcoded 100000 with PER_USER_RANGE constant; updated manager existence check to normalize np->uid |
| kernel/allowlist.c | Updated manager UID comparisons in __ksu_is_allow_uid() and ksu_uid_should_umount() to normalize uid parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
6b039d6 to
2b80784
Compare
appid is same for a single package across users, so we can identify manager without PER_USER_RANGE. Note, KSU_IOCTL_GET_MANAGER_UID will return real appid now.
KOWX712
pushed a commit
to KOWX712/KernelSU
that referenced
this pull request
Dec 6, 2025
appid is same for a single package across users, so we can identify manager without PER_USER_RANGE. Note, KSU_IOCTL_GET_MANAGER_UID will return real appid now.
selfmusing
pushed a commit
to selfmusing/USlenreK
that referenced
this pull request
Dec 11, 2025
appid is same for a single package across users, so we can identify manager without PER_USER_RANGE. Note, KSU_IOCTL_GET_MANAGER_UID will return real appid now.
larpedd
pushed a commit
to larpedd/KernelSU
that referenced
this pull request
Dec 20, 2025
appid is same for a single package across users, so we can identify manager without PER_USER_RANGE. Note, KSU_IOCTL_GET_MANAGER_UID will return real appid now.
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 5, 2026
appid is same for a single package across users, so we can identify manager without PER_USER_RANGE. Note, KSU_IOCTL_GET_MANAGER_UID will return real appid now.
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 5, 2026
appid is same for a single package across users, so we can identify manager without PER_USER_RANGE. Note, KSU_IOCTL_GET_MANAGER_UID will return real appid now.
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 8, 2026
appid is same for a single package across users, so we can identify manager without PER_USER_RANGE. Note, KSU_IOCTL_GET_MANAGER_UID will return real appid now.
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 13, 2026
appid is same for a single package across users, so we can identify manager without PER_USER_RANGE. Note, KSU_IOCTL_GET_MANAGER_UID will return real appid now.
LeCmnGend
pushed a commit
to LeCmnGend/KernelSU
that referenced
this pull request
Feb 23, 2026
appid is same for a single package across users, so we can identify manager without PER_USER_RANGE. Note, KSU_IOCTL_GET_MANAGER_UID will return real appid now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
appid is same for a single package across users, so we can identify manager without PER_USER_RANGE. Note, KSU_IOCTL_GET_MANAGER_UID will return real appid now.