Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors credential management for unmounting operations by introducing a globally shared ksu_cred credential instead of using per-task credentials. The change eliminates the need for zygote processes to have special SELinux permissions for unmounting modules.
Key changes:
- Introduced a global
ksu_credcredential initialized during module init and configured with the KernelSU SELinux context during init's second stage - Refactored
transive_to_domain()to accept a credential parameter instead of always using the current task's credential - Simplified
umount_tw_func()to use the sharedksu_credinstead of storing and managing per-task credentials
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| kernel/ksu.h | Declares the global ksu_cred variable for external access |
| kernel/ksu.c | Initializes ksu_cred in module init and properly releases it in module exit |
| kernel/selinux/selinux.h | Adds declaration for setup_ksu_cred() function |
| kernel/selinux/selinux.c | Refactors transive_to_domain() to accept credential parameter and adds setup_ksu_cred() to configure the global credential's SELinux context |
| kernel/ksud.c | Calls setup_ksu_cred() during init second stage to properly configure the credential |
| kernel/kernel_umount.c | Simplifies unmount credential handling by using the shared ksu_cred instead of managing per-task credentials |
| kernel/selinux/rules.c | Removes zygote SELinux rule that is no longer needed since unmounting no longer happens in zygote context |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ylarod
approved these changes
Dec 3, 2025
aviraxp
approved these changes
Dec 3, 2025
KOWX712
pushed a commit
to KOWX712/KernelSU
that referenced
this pull request
Dec 3, 2025
larpedd
pushed a commit
to larpedd/KernelSU
that referenced
this pull request
Dec 20, 2025
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 5, 2026
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 5, 2026
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 8, 2026
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 13, 2026
RapliVx
pushed a commit
to RapliVx/KernelSU
that referenced
this pull request
Jan 26, 2026
LeCmnGend
pushed a commit
to LeCmnGend/KernelSU
that referenced
this pull request
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.