kernel: Move kernel part build rules from Makefile to Kbuild#3003
Merged
Conversation
This commit reorganizes the KernelSU build system by relocating all kernel-specific build definitions—previously embedded in `kernel/Makefile`—into a dedicated `kernel/Kbuild` file, in strict accordance with the Linux kernel's out-of-tree module conventions. The `Kbuild` file is the standard and only appropriate location for declaring: - Object file lists (`kernelsu-objs`), - Compiler flags (`ccflags-y`), - Conditional logic for versioning (Git revision count), - Security-related macros (e.g., `KSU_VERSION`, `EXPECTED_HASH`, `KSU_MANAGER_PACKAGE`), - Header include paths and warning suppressions. The top-level `kernel/Makefile` is now reduced to its intended role: a minimal user-facing entry point that invokes the kernel’s build system via `make -C $(KDIR) M=$(MDIR) modules`. This separation ensures compatibility with the kernel’s build infrastructure (including `O=` out-of-source builds, LLVM builds, and modpost) and adheres to guidelines in `Documentation/kbuild/modules.rst`. No functional or behavioral changes are introduced—this is a pure build-system refactor to improve correctness, maintainability, and alignment with upstream practices. Signed-off-by: dabao1955 <dabao1955@163.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the KernelSU build system by moving kernel module build definitions from kernel/Makefile to kernel/Kbuild, following Linux kernel out-of-tree module conventions. The Makefile now serves only as a user-facing entry point that invokes the kernel build system.
Key Changes:
- Relocated all object file declarations (
kernelsu-objs), compiler flags (ccflags-y), and versioning logic from Makefile to Kbuild - Simplified Makefile to contain only build invocation targets (all, compdb, clean)
- Maintained all functional definitions including git version detection, manager signature configuration, and warning suppressions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| kernel/Makefile | Simplified to contain only PHONY targets that invoke the kernel build system via make -C $(KDIR) M=$(MDIR) modules |
| kernel/Kbuild | New file containing all kernel module build rules, object file lists, compiler flags, versioning logic, and security macros previously in Makefile |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit 1d64c82.
Collaborator
|
missing kernel/selinux/Makefile |
Contributor
Author
kernel/selinux objects already defined in Kbuild. CC [M] /__w/KernelSU/KernelSU/kernel/selinux/selinux.o
CC [M] /__w/KernelSU/KernelSU/kernel/selinux/sepolicy.o
CC [M] /__w/KernelSU/KernelSU/kernel/selinux/rules.o
LD [M] /__w/KernelSU/KernelSU/kernel/kernelsu.o |
Collaborator
|
so remove it, since it's not needed |
selinux objects already defined on Kbuild.
Contributor
Author
Deleted. |
Contributor
Author
|
CC @Ylarod please review |
KOWX712
pushed a commit
to KOWX712/KernelSU
that referenced
this pull request
Nov 29, 2025
) This commit reorganizes the KernelSU build system by relocating all kernel-specific build definitions—previously embedded in `kernel/Makefile`—into a dedicated `kernel/Kbuild` file, in strict accordance with the Linux kernel's out-of-tree module conventions. The `Kbuild` file is the standard and only appropriate location for declaring: - Object file lists (`kernelsu-objs`), - Compiler flags (`ccflags-y`), - Conditional logic for versioning (Git revision count), - Security-related macros (e.g., `KSU_VERSION`, `EXPECTED_HASH`, `KSU_MANAGER_PACKAGE`), - Header include paths and warning suppressions. The top-level `kernel/Makefile` is now reduced to its intended role: a minimal user-facing entry point that invokes the kernel’s build system via `make -C $(KDIR) M=$(MDIR) modules`. This separation ensures compatibility with the kernel’s build infrastructure (including `O=` out-of-source builds, LLVM builds, and modpost) and adheres to guidelines in `Documentation/kbuild/modules.rst`. No functional or behavioral changes are introduced—this is a pure build-system refactor to improve correctness, maintainability, and alignment with upstream practices. --------- Signed-off-by: dabao1955 <dabao1955@163.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
KOWX712
pushed a commit
to KOWX712/KernelSU
that referenced
this pull request
Nov 29, 2025
) This commit reorganizes the KernelSU build system by relocating all kernel-specific build definitions—previously embedded in `kernel/Makefile`—into a dedicated `kernel/Kbuild` file, in strict accordance with the Linux kernel's out-of-tree module conventions. The `Kbuild` file is the standard and only appropriate location for declaring: - Object file lists (`kernelsu-objs`), - Compiler flags (`ccflags-y`), - Conditional logic for versioning (Git revision count), - Security-related macros (e.g., `KSU_VERSION`, `EXPECTED_HASH`, `KSU_MANAGER_PACKAGE`), - Header include paths and warning suppressions. The top-level `kernel/Makefile` is now reduced to its intended role: a minimal user-facing entry point that invokes the kernel’s build system via `make -C $(KDIR) M=$(MDIR) modules`. This separation ensures compatibility with the kernel’s build infrastructure (including `O=` out-of-source builds, LLVM builds, and modpost) and adheres to guidelines in `Documentation/kbuild/modules.rst`. No functional or behavioral changes are introduced—this is a pure build-system refactor to improve correctness, maintainability, and alignment with upstream practices. --------- Signed-off-by: dabao1955 <dabao1955@163.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
larpedd
pushed a commit
to larpedd/KernelSU
that referenced
this pull request
Dec 20, 2025
) This commit reorganizes the KernelSU build system by relocating all kernel-specific build definitions—previously embedded in `kernel/Makefile`—into a dedicated `kernel/Kbuild` file, in strict accordance with the Linux kernel's out-of-tree module conventions. The `Kbuild` file is the standard and only appropriate location for declaring: - Object file lists (`kernelsu-objs`), - Compiler flags (`ccflags-y`), - Conditional logic for versioning (Git revision count), - Security-related macros (e.g., `KSU_VERSION`, `EXPECTED_HASH`, `KSU_MANAGER_PACKAGE`), - Header include paths and warning suppressions. The top-level `kernel/Makefile` is now reduced to its intended role: a minimal user-facing entry point that invokes the kernel’s build system via `make -C $(KDIR) M=$(MDIR) modules`. This separation ensures compatibility with the kernel’s build infrastructure (including `O=` out-of-source builds, LLVM builds, and modpost) and adheres to guidelines in `Documentation/kbuild/modules.rst`. No functional or behavioral changes are introduced—this is a pure build-system refactor to improve correctness, maintainability, and alignment with upstream practices. --------- Signed-off-by: dabao1955 <dabao1955@163.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 5, 2026
) This commit reorganizes the KernelSU build system by relocating all kernel-specific build definitions—previously embedded in `kernel/Makefile`—into a dedicated `kernel/Kbuild` file, in strict accordance with the Linux kernel's out-of-tree module conventions. The `Kbuild` file is the standard and only appropriate location for declaring: - Object file lists (`kernelsu-objs`), - Compiler flags (`ccflags-y`), - Conditional logic for versioning (Git revision count), - Security-related macros (e.g., `KSU_VERSION`, `EXPECTED_HASH`, `KSU_MANAGER_PACKAGE`), - Header include paths and warning suppressions. The top-level `kernel/Makefile` is now reduced to its intended role: a minimal user-facing entry point that invokes the kernel’s build system via `make -C $(KDIR) M=$(MDIR) modules`. This separation ensures compatibility with the kernel’s build infrastructure (including `O=` out-of-source builds, LLVM builds, and modpost) and adheres to guidelines in `Documentation/kbuild/modules.rst`. No functional or behavioral changes are introduced—this is a pure build-system refactor to improve correctness, maintainability, and alignment with upstream practices. --------- Signed-off-by: dabao1955 <dabao1955@163.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 5, 2026
) This commit reorganizes the KernelSU build system by relocating all kernel-specific build definitions—previously embedded in `kernel/Makefile`—into a dedicated `kernel/Kbuild` file, in strict accordance with the Linux kernel's out-of-tree module conventions. The `Kbuild` file is the standard and only appropriate location for declaring: - Object file lists (`kernelsu-objs`), - Compiler flags (`ccflags-y`), - Conditional logic for versioning (Git revision count), - Security-related macros (e.g., `KSU_VERSION`, `EXPECTED_HASH`, `KSU_MANAGER_PACKAGE`), - Header include paths and warning suppressions. The top-level `kernel/Makefile` is now reduced to its intended role: a minimal user-facing entry point that invokes the kernel’s build system via `make -C $(KDIR) M=$(MDIR) modules`. This separation ensures compatibility with the kernel’s build infrastructure (including `O=` out-of-source builds, LLVM builds, and modpost) and adheres to guidelines in `Documentation/kbuild/modules.rst`. No functional or behavioral changes are introduced—this is a pure build-system refactor to improve correctness, maintainability, and alignment with upstream practices. --------- Signed-off-by: dabao1955 <dabao1955@163.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 8, 2026
) This commit reorganizes the KernelSU build system by relocating all kernel-specific build definitions—previously embedded in `kernel/Makefile`—into a dedicated `kernel/Kbuild` file, in strict accordance with the Linux kernel's out-of-tree module conventions. The `Kbuild` file is the standard and only appropriate location for declaring: - Object file lists (`kernelsu-objs`), - Compiler flags (`ccflags-y`), - Conditional logic for versioning (Git revision count), - Security-related macros (e.g., `KSU_VERSION`, `EXPECTED_HASH`, `KSU_MANAGER_PACKAGE`), - Header include paths and warning suppressions. The top-level `kernel/Makefile` is now reduced to its intended role: a minimal user-facing entry point that invokes the kernel’s build system via `make -C $(KDIR) M=$(MDIR) modules`. This separation ensures compatibility with the kernel’s build infrastructure (including `O=` out-of-source builds, LLVM builds, and modpost) and adheres to guidelines in `Documentation/kbuild/modules.rst`. No functional or behavioral changes are introduced—this is a pure build-system refactor to improve correctness, maintainability, and alignment with upstream practices. --------- Signed-off-by: dabao1955 <dabao1955@163.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 13, 2026
) This commit reorganizes the KernelSU build system by relocating all kernel-specific build definitions—previously embedded in `kernel/Makefile`—into a dedicated `kernel/Kbuild` file, in strict accordance with the Linux kernel's out-of-tree module conventions. The `Kbuild` file is the standard and only appropriate location for declaring: - Object file lists (`kernelsu-objs`), - Compiler flags (`ccflags-y`), - Conditional logic for versioning (Git revision count), - Security-related macros (e.g., `KSU_VERSION`, `EXPECTED_HASH`, `KSU_MANAGER_PACKAGE`), - Header include paths and warning suppressions. The top-level `kernel/Makefile` is now reduced to its intended role: a minimal user-facing entry point that invokes the kernel’s build system via `make -C $(KDIR) M=$(MDIR) modules`. This separation ensures compatibility with the kernel’s build infrastructure (including `O=` out-of-source builds, LLVM builds, and modpost) and adheres to guidelines in `Documentation/kbuild/modules.rst`. No functional or behavioral changes are introduced—this is a pure build-system refactor to improve correctness, maintainability, and alignment with upstream practices. --------- Signed-off-by: dabao1955 <dabao1955@163.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
RapliVx
pushed a commit
to RapliVx/KernelSU
that referenced
this pull request
Jan 26, 2026
) This commit reorganizes the KernelSU build system by relocating all kernel-specific build definitions—previously embedded in `kernel/Makefile`—into a dedicated `kernel/Kbuild` file, in strict accordance with the Linux kernel's out-of-tree module conventions. The `Kbuild` file is the standard and only appropriate location for declaring: - Object file lists (`kernelsu-objs`), - Compiler flags (`ccflags-y`), - Conditional logic for versioning (Git revision count), - Security-related macros (e.g., `KSU_VERSION`, `EXPECTED_HASH`, `KSU_MANAGER_PACKAGE`), - Header include paths and warning suppressions. The top-level `kernel/Makefile` is now reduced to its intended role: a minimal user-facing entry point that invokes the kernel’s build system via `make -C $(KDIR) M=$(MDIR) modules`. This separation ensures compatibility with the kernel’s build infrastructure (including `O=` out-of-source builds, LLVM builds, and modpost) and adheres to guidelines in `Documentation/kbuild/modules.rst`. No functional or behavioral changes are introduced—this is a pure build-system refactor to improve correctness, maintainability, and alignment with upstream practices. --------- Signed-off-by: dabao1955 <dabao1955@163.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
LeCmnGend
pushed a commit
to LeCmnGend/KernelSU
that referenced
this pull request
Feb 23, 2026
) This commit reorganizes the KernelSU build system by relocating all kernel-specific build definitions—previously embedded in `kernel/Makefile`—into a dedicated `kernel/Kbuild` file, in strict accordance with the Linux kernel's out-of-tree module conventions. The `Kbuild` file is the standard and only appropriate location for declaring: - Object file lists (`kernelsu-objs`), - Compiler flags (`ccflags-y`), - Conditional logic for versioning (Git revision count), - Security-related macros (e.g., `KSU_VERSION`, `EXPECTED_HASH`, `KSU_MANAGER_PACKAGE`), - Header include paths and warning suppressions. The top-level `kernel/Makefile` is now reduced to its intended role: a minimal user-facing entry point that invokes the kernel’s build system via `make -C $(KDIR) M=$(MDIR) modules`. This separation ensures compatibility with the kernel’s build infrastructure (including `O=` out-of-source builds, LLVM builds, and modpost) and adheres to guidelines in `Documentation/kbuild/modules.rst`. No functional or behavioral changes are introduced—this is a pure build-system refactor to improve correctness, maintainability, and alignment with upstream practices. --------- Signed-off-by: dabao1955 <dabao1955@163.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit reorganizes the KernelSU build system by relocating all kernel-specific build definitions—previously embedded in
kernel/Makefile—into a dedicatedkernel/Kbuildfile, in strict accordance with the Linux kernel's out-of-tree module conventions.The
Kbuildfile is the standard and only appropriate location for declaring:kernelsu-objs),ccflags-y),KSU_VERSION,EXPECTED_HASH,KSU_MANAGER_PACKAGE),The top-level
kernel/Makefileis now reduced to its intended role: a minimal user-facing entry point that invokes the kernel’s build system viamake -C $(KDIR) M=$(MDIR) modules. This separation ensures compatibility with the kernel’s build infrastructure (includingO=out-of-source builds, LLVM builds, and modpost) and adheres to guidelines inDocumentation/kbuild/modules.rst.No functional or behavioral changes are introduced—this is a pure build-system refactor to improve correctness, maintainability, and alignment with upstream practices.