manager: add inset support to webui#2952

Merged

tiann merged 3 commits into

Nov 18, 2025

KOWX712 commented Nov 18, 2025

Collaborator

ref: https://github.com/MMRLApp/WebUI-X-Portable/blob/master/webui/src/main/kotlin/com/dergoogler/mmrl/webui/model/Insets.kt

Co-Authored-By: Der_Googler 54764558+dergoogler@users.noreply.github.com
Signed-off-by: KOWX712 leecc0503@gmail.com


          manager: add inset support to webui

0e72b14

ref: https://github.com/MMRLApp/WebUI-X-Portable/blob/master/webui/src/main/kotlin/com/dergoogler/mmrl/webui/model/Insets.kt

Co-Authored-By: Der_Googler <54764558+dergoogler@users.noreply.github.com>
Signed-off-by: KOWX712 <leecc0503@gmail.com>

KOWX712 commented Nov 18, 2025 •

edited

Loading

Collaborator Author

This standard is used in WebUI-X (also known as MMRL) for quite a while, many module's webui has already added support to this, here is a simple guide to add inset support in webui:

@import url('https://mui.kernelsu.org/internal/insets.css');

body {
    padding-top: var(--window-inset-top, 0px);
    padding-bottom: var(--window-inset-bottom, 0px);
}

Old WebUI vs New WebUI

tiann requested a review from Copilot

November 18, 2025 12:04

Copilot started reviewing on behalf of tiann

November 18, 2025 12:05

Copilot finished reviewing on behalf of tiann

November 18, 2025 12:06

Copilot AI reviewed

View reviewed changes

Copilot AI left a comment

Contributor

Pull Request Overview

This pull request adds window insets support to the WebUI feature, allowing web content to properly adapt to device safe areas (status bars, navigation bars, and notches). The implementation is inspired by WebUI-X-Portable project.

Introduces a new Insets data class that captures and converts system window insets to CSS variables
Updates WebView configuration to track window insets and expose them via a dynamically generated CSS file
Modifies SuFilePathHandler to serve the generated insets CSS at a special internal/insets.css path

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
manager/app/src/main/java/me/weishu/kernelsu/ui/webui/Inset.kt	New data class that stores inset values and generates CSS variables for safe area handling
manager/app/src/main/java/me/weishu/kernelsu/ui/webui/WebUIActivity.kt	Updates WebView setup to capture system window insets, convert them from pixels to dp, and pass them to the path handler via a supplier interface
manager/app/src/main/java/me/weishu/kernelsu/ui/webui/SuFilePathHandler.java	Adds `InsetsSupplier` interface and special handling for `internal/insets.css` path to serve dynamically generated insets CSS

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

manager/app/src/main/java/me/weishu/kernelsu/ui/webui/Insets.kt

manager/app/src/main/java/me/weishu/kernelsu/ui/webui/Insets.kt


          rename

e6bb678

Seyud approved these changes

View reviewed changes

tiann requested a review from YuKongA

November 18, 2025 12:20


          add displayCutout to inset

2fb0508

Co-Authored-By: Light_summer <93428659+lightsummer233@users.noreply.github.com>

YuKongA approved these changes

View reviewed changes

tiann merged commit 4b94c8e into tiann:main

15 checks passed

KOWX712 deleted the inset branch

November 18, 2025 14:46

wxyShine mentioned this pull request

[Feature]: 适配下最新ksu Zephyruso/zashboard#539

Open

rsuntk pushed a commit to rsuntk/KernelSU that referenced this pull request


          manager: add inset support to webui (tiann#2952)

1a02515

ref:
https://github.com/MMRLApp/WebUI-X-Portable/blob/master/webui/src/main/kotlin/com/dergoogler/mmrl/webui/model/Insets.kt

Co-Authored-By: Der_Googler
<54764558+dergoogler@users.noreply.github.com>
Signed-off-by: KOWX712 <leecc0503@gmail.com>

---------

Signed-off-by: KOWX712 <leecc0503@gmail.com>
Co-authored-by: Der_Googler <54764558+dergoogler@users.noreply.github.com>
Co-authored-by: Light_summer <93428659+lightsummer233@users.noreply.github.com>
Signed-off-by: fc5b87cf <rissu.ntk@gmail.com>

Seyud mentioned this pull request

模块WebUI在新版KernelSU打开页面冲突 twoone-3/AdGuardHomeForRoot#44

Closed

YuzakiKokuban pushed a commit to YuzakiKokuban/hymo that referenced this pull request


          webui: Fix safe area

a2e4487

Link: tiann/KernelSU#2952 (comment)

elysias123 mentioned this pull request

webui重定向后渲染异常 #3075

Closed

3 tasks

KOWX712 mentioned this pull request

js: add insets documentation and function #3084

Merged

aviraxp pushed a commit that referenced this pull request


          js: add insets documentation and function (#3084)

documentation for #2952, #3083

Signed-off-by: KOWX712 <leecc0503@gmail.com>

KOWX712 added a commit to KOWX712/KernelSU that referenced this pull request


          js: add insets documentation and function (tiann#3084)

7ef3cfc

documentation for tiann#2952, tiann#3083

Signed-off-by: KOWX712 <leecc0503@gmail.com>

KOWX712 added a commit to KOWX712/APatch that referenced this pull request


          manager: add insets support to webui

6aac3c6

sync tiann/KernelSU#2952, tiann/KernelSU#3083

add insets support to WebUI, no change are required for existing WebUI module.

Co-Authored-By: Der_Googler <54764558+dergoogler@users.noreply.github.com>
Co-Authored-By: Light_summer <93428659+lightsummer233@users.noreply.github.com>
Signed-off-by: KOWX712 <leecc0503@gmail.com>

KOWX712 mentioned this pull request

manager: add insets support to webui bmax121/APatch#1340

Merged

bklynali pushed a commit to bklynali/BK-KSU that referenced this pull request


          js: add insets documentation and function (tiann#3084)

e5ddde7

documentation for tiann#2952, tiann#3083

Signed-off-by: KOWX712 <leecc0503@gmail.com>

KOWX712 added a commit to KOWX712/KsuWebUIStandalone that referenced this pull request


          add insets support to webui

2c8318b

ref: tiann/KernelSU#2952, tiann/KernelSU#3083

Co-Authored-By: Der_Googler <54764558+dergoogler@users.noreply.github.com>
Co-Authored-By: Light_summer <93428659+lightsummer233@users.noreply.github.com>
Signed-off-by: KOWX712 <leecc0503@gmail.com>

KOWX712 added a commit to KOWX712/KsuWebUIStandalone that referenced this pull request


          add insets support to webui

6a4e78f

ref: tiann/KernelSU#2952, tiann/KernelSU#3083

Co-Authored-By: Der_Googler <54764558+dergoogler@users.noreply.github.com>
Co-Authored-By: Light_summer <93428659+lightsummer233@users.noreply.github.com>
Signed-off-by: KOWX712 <leecc0503@gmail.com>

KOWX712 added a commit to KOWX712/KsuWebUIStandalone that referenced this pull request


          add insets support to webui

c5d94c0

ref: tiann/KernelSU#2952, tiann/KernelSU#3083

Co-Authored-By: Der_Googler <54764558+dergoogler@users.noreply.github.com>
Co-Authored-By: Light_summer <93428659+lightsummer233@users.noreply.github.com>
Signed-off-by: KOWX712 <leecc0503@gmail.com>

KOWX712 added a commit to KOWX712/KsuWebUIStandalone that referenced this pull request


          add insets support to webui

64dda03

ref: tiann/KernelSU#2952, tiann/KernelSU#3083

Co-Authored-By: Der_Googler <54764558+dergoogler@users.noreply.github.com>
Co-Authored-By: Light_summer <93428659+lightsummer233@users.noreply.github.com>
Signed-off-by: KOWX712 <leecc0503@gmail.com>

KOWX712 added a commit to KOWX712/KsuWebUIStandalone that referenced this pull request


          add insets support to webui

3b4e49f

ref: tiann/KernelSU#2952, tiann/KernelSU#3083

Co-Authored-By: Der_Googler <54764558+dergoogler@users.noreply.github.com>
Co-Authored-By: Light_summer <93428659+lightsummer233@users.noreply.github.com>
Signed-off-by: KOWX712 <leecc0503@gmail.com>

KOWX712 added a commit to KOWX712/KsuWebUIStandalone that referenced this pull request


          add insets support to webui

0518fcc

ref: tiann/KernelSU#2952, tiann/KernelSU#3083

Co-Authored-By: Der_Googler <54764558+dergoogler@users.noreply.github.com>
Co-Authored-By: Light_summer <93428659+lightsummer233@users.noreply.github.com>
Signed-off-by: KOWX712 <leecc0503@gmail.com>

u9521 pushed a commit to u9521/KernelSU that referenced this pull request


          manager: add inset support to webui (tiann#2952)

5e35e33

ref:
https://github.com/MMRLApp/WebUI-X-Portable/blob/master/webui/src/main/kotlin/com/dergoogler/mmrl/webui/model/Insets.kt

Co-Authored-By: Der_Googler
<54764558+dergoogler@users.noreply.github.com>
Signed-off-by: KOWX712 <leecc0503@gmail.com>

---------

Signed-off-by: KOWX712 <leecc0503@gmail.com>
Co-authored-by: Der_Googler <54764558+dergoogler@users.noreply.github.com>
Co-authored-by: Light_summer <93428659+lightsummer233@users.noreply.github.com>

u9521 pushed a commit to u9521/KernelSU that referenced this pull request


          js: add insets documentation and function (tiann#3084)

ad14bcb

documentation for tiann#2952, tiann#3083

Signed-off-by: KOWX712 <leecc0503@gmail.com>

u9521 pushed a commit to u9521/KernelSU that referenced this pull request


          manager: add inset support to webui (tiann#2952)

d8b2bc1

ref:
https://github.com/MMRLApp/WebUI-X-Portable/blob/master/webui/src/main/kotlin/com/dergoogler/mmrl/webui/model/Insets.kt

Co-Authored-By: Der_Googler
<54764558+dergoogler@users.noreply.github.com>
Signed-off-by: KOWX712 <leecc0503@gmail.com>

---------

Signed-off-by: KOWX712 <leecc0503@gmail.com>
Co-authored-by: Der_Googler <54764558+dergoogler@users.noreply.github.com>
Co-authored-by: Light_summer <93428659+lightsummer233@users.noreply.github.com>

u9521 pushed a commit to u9521/KernelSU that referenced this pull request


          js: add insets documentation and function (tiann#3084)

documentation for tiann#2952, tiann#3083

Signed-off-by: KOWX712 <leecc0503@gmail.com>

Prslc pushed a commit to Prslc/APatch that referenced this pull request


          manager: add insets support to webui

f972b97

sync tiann/KernelSU#2952, tiann/KernelSU#3083

add insets support to WebUI, no change are required for existing WebUI module.

minor touch up

manager: fix ksu.fullScreen

ref: tiann/KernelSU#3126

Co-Authored-By: Der_Googler <54764558+dergoogler@users.noreply.github.com>
Co-Authored-By: Light_summer <93428659+lightsummer233@users.noreply.github.com>
Signed-off-by: KOWX712 <leecc0503@gmail.com>

u9521 pushed a commit to u9521/KernelSU that referenced this pull request


          js: add insets documentation and function (tiann#3084)

e22e6fc

documentation for tiann#2952, tiann#3083

Signed-off-by: KOWX712 <leecc0503@gmail.com>

Admirepowered pushed a commit to bmax121/APatch that referenced this pull request


          manager: add insets support to webui (#1340)

2f05933

sync tiann/KernelSU#2952, tiann/KernelSU#3083

add insets support to WebUI, no change are required for existing WebUI module.



Signed-off-by: KOWX712 <leecc0503@gmail.com>
Co-authored-by: Der_Googler <54764558+dergoogler@users.noreply.github.com>
Co-authored-by: Light_summer <93428659+lightsummer233@users.noreply.github.com>

Prslc pushed a commit to Prslc/APatch that referenced this pull request


          manager: add insets support to webui (bmax121#1340)

8529b0f

sync tiann/KernelSU#2952, tiann/KernelSU#3083

add insets support to WebUI, no change are required for existing WebUI module.

minor touch up

manager: fix ksu.fullScreen

ref: tiann/KernelSU#3126

Co-Authored-By: Der_Googler <54764558+dergoogler@users.noreply.github.com>
Co-Authored-By: Light_summer <93428659+lightsummer233@users.noreply.github.com>
Signed-off-by: KOWX712 <leecc0503@gmail.com>

u9521 pushed a commit to u9521/KernelSU that referenced this pull request


          manager: add inset support to webui (tiann#2952)

a441b7d

ref:
https://github.com/MMRLApp/WebUI-X-Portable/blob/master/webui/src/main/kotlin/com/dergoogler/mmrl/webui/model/Insets.kt

Co-Authored-By: Der_Googler
<54764558+dergoogler@users.noreply.github.com>
Signed-off-by: KOWX712 <leecc0503@gmail.com>

---------

Signed-off-by: KOWX712 <leecc0503@gmail.com>
Co-authored-by: Der_Googler <54764558+dergoogler@users.noreply.github.com>
Co-authored-by: Light_summer <93428659+lightsummer233@users.noreply.github.com>

u9521 pushed a commit to u9521/KernelSU that referenced this pull request


          js: add insets documentation and function (tiann#3084)

f8d96ab

documentation for tiann#2952, tiann#3083

Signed-off-by: KOWX712 <leecc0503@gmail.com>

KOWX712 added a commit to KOWX712/KsuWebUIStandalone that referenced this pull request


          add insets support to webui

d4b533e

ref: tiann/KernelSU#2952, tiann/KernelSU#3083

Co-Authored-By: Der_Googler <54764558+dergoogler@users.noreply.github.com>
Co-Authored-By: Light_summer <93428659+lightsummer233@users.noreply.github.com>
Signed-off-by: KOWX712 <leecc0503@gmail.com>

KOWX712 added a commit to KOWX712/KsuWebUIStandalone that referenced this pull request


          add insets support to webui

76c9fd3

ref: tiann/KernelSU#2952, tiann/KernelSU#3083

Co-Authored-By: Der_Googler <54764558+dergoogler@users.noreply.github.com>
Co-Authored-By: Light_summer <93428659+lightsummer233@users.noreply.github.com>
Signed-off-by: KOWX712 <leecc0503@gmail.com>

KOWX712 added a commit to KOWX712/KsuWebUIStandalone that referenced this pull request


          add insets support to webui

67c7b01

ref: tiann/KernelSU#2952, tiann/KernelSU#3083

Co-Authored-By: Der_Googler <54764558+dergoogler@users.noreply.github.com>
Co-Authored-By: Light_summer <93428659+lightsummer233@users.noreply.github.com>
Signed-off-by: KOWX712 <leecc0503@gmail.com>

KOWX712 added a commit to KOWX712/KsuWebUIStandalone that referenced this pull request


          add insets support to webui

11d6dea

ref: tiann/KernelSU#2952, tiann/KernelSU#3083

Co-Authored-By: Der_Googler <54764558+dergoogler@users.noreply.github.com>
Co-Authored-By: Light_summer <93428659+lightsummer233@users.noreply.github.com>
Signed-off-by: KOWX712 <leecc0503@gmail.com>

KOWX712 added a commit to KOWX712/FolkPatch that referenced this pull request


          fix(webui): defer loadUrl until WebView is laid out and support insets

4cf9a95

The WebUI failed to load CSS/JS assets because the WebView was configured and loadUrl was called inside the AndroidView factory during Compose composition, which blocked the main thread and called loadUrl before the WebView had valid dimensions.
Refactor to match the KernelSU pattern:
- Create WebView and configure WebViewAssetLoader on IO dispatcher
- Build WebView fully on Main thread outside AndroidView
- Defer loadUrl until width > 0 && height > 0 via layout listener

- related:
  - tiann/KernelSU#2952
  - tiann/KernelSU#3083
  - tiann/KernelSU#3126
  - tiann/KernelSU#3190

Signed-off-by: KOWX712 <leecc0503@gmail.com>

KOWX712 mentioned this pull request

fix: defer loadUrl until WebView is laid out and support insets LyraVoid/FolkPatch#151

Merged

matsuzaka-yuki pushed a commit to LyraVoid/FolkPatch that referenced this pull request


          fix(webui): defer loadUrl until WebView is laid out and support insets (

7300dac

#151)

The WebUI failed to load CSS/JS assets because the WebView was configured and loadUrl was called inside the AndroidView factory during Compose composition, which blocked the main thread and called loadUrl before the WebView had valid dimensions.
Refactor to match the KernelSU pattern:
- Create WebView and configure WebViewAssetLoader on IO dispatcher
- Build WebView fully on Main thread outside AndroidView
- Defer loadUrl until width > 0 && height > 0 via layout listener

- related:
  - tiann/KernelSU#2952
  - tiann/KernelSU#3083
  - tiann/KernelSU#3126
  - tiann/KernelSU#3190

Signed-off-by: KOWX712 <leecc0503@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet