manager: introduce webui package manager api by KOWX712 · Pull Request #2928 · tiann/KernelSU

KOWX712 · 2025-11-13T12:13:05Z

this is a squash of:

manager: introduce app package info API for webui-next (KernelSU-Next/KernelSU-Next@58167a4)
manager: sort a-z order for webui-next list packages api (KernelSU-Next/KernelSU-Next@4a9733c)
manager: implement getPackagesIcons and cacheAllPackageIcons api to webui-next (KernelSU-Next/KernelSU-Next@a361fa3)
manager/webui: let getPackagesIcons generate icon and store in cache as well when called (KernelSU-Next/KernelSU-Next@6afa86d)
POC: load icon app via ksu://icon/[packageName] (KernelSU-Next#674) (KernelSU-Next/KernelSU-Next@bc9927b)
manager: refine webui package manager (KOWX712/KernelSU@0400c42)

Co-Authored-By: Rifat Azad 33044977+rifsxd@users.noreply.github.com
Co-Authored-By: Fahrez256Bit 167403685+fahrez256@users.noreply.github.com
Signed-off-by: KOWX712 leecc0503@gmail.com

this is a squash of: * manager: introduce app package info API for webui-next (KernelSU-Next/KernelSU-Next@58167a4) * manager: sort a-z order for webui-next list packages api (KernelSU-Next/KernelSU-Next@4a9733c) * manager: implement getPackagesIcons and cacheAllPackageIcons api to webui-next (KernelSU-Next/KernelSU-Next@a361fa3) * manager/webui: let getPackagesIcons generate icon and store in cache as well when called (KernelSU-Next/KernelSU-Next@6afa86d) * POC: load icon app via ksu://icon/[packageName] (KernelSU-Next#674) (KernelSU-Next/KernelSU-Next@bc9927b) * manager: refine webui package manager (0400c42) Co-Authored-By: Rifat Azad <33044977+rifsxd@users.noreply.github.com> Co-Authored-By: Fahrez256Bit <167403685+fahrez256@users.noreply.github.com> Signed-off-by: KOWX712 <leecc0503@gmail.com>

KOWX712 · 2025-11-13T12:15:12Z

这里同时提供了 ksu://icon/[packageName] 和 getPackagesIcons() 两种获取图标的方式，如果觉得不需要可以移除 getPackagesIcons()

Copilot

Pull Request Overview

This PR introduces a comprehensive package manager API for the WebUI, enabling web-based modules to query installed applications and retrieve their metadata and icons. The changes include JavaScript interface methods for package listing, detailed package information retrieval, and icon caching mechanisms, along with a custom ksu://icon/[packageName] URL scheme handler.

Adds JavaScript interface APIs (listPackages, getPackagesInfo, getPackagesIcons, cacheAllPackageIcons) for package management in WebView
Implements dual icon caching strategies: Base64-encoded strings for JavaScript access and bitmap cache for URL-based access
Preloads app list at application startup for improved initial response time

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 15 comments.

Show a summary per file

File	Description
WebViewInterface.kt	Implements four new JavaScript interface methods for package listing, metadata retrieval, and icon encoding with Base64 caching
WebUIActivity.kt	Adds `ksu://icon/` URL scheme handler to serve app icons directly via WebView requests and initializes SuperUserViewModel
AppIconUtil.java	Provides utility for synchronous icon loading with bitmap caching for the URL handler
SuperUserViewModel.kt	Exposes static `apps` list and `getAppIconDrawable()` helper for cross-component access
KernelSUApplication.kt	Implements ViewModelStoreOwner and preloads app list during application initialization

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…nterface.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

The @RequiresApi(Build.VERSION_CODES.P) annotation is unnecessary here. The PackageInfo.longVersionCode property (line 246) was indeed added in API 28 (P), but this annotation doesn't prevent runtime crashes on older APIs. Consider using a version check or the compat accessor PackageInfoCompat.getLongVersionCode() from AndroidX core library for backward compatibility. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Memory leak: Bitmaps stored in the cache are never cleared, which can lead to memory exhaustion over time, especially with many applications installed. Consider implementing a size-limited cache (e.g., using LruCache) or clearing the cache when appropriate. Co-Authored-By: Copilot <175728472+Copilot@users.noreply.github.com>

…til.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

The static apps field is accessed from multiple threads without synchronization. The field is written in fetchAppList() (line 173 in the full file) which runs on IO dispatcher, but is read from WebView JavaScript interface methods which run on arbitrary threads. This can lead to race conditions and visibility issues.

…til.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

KOWX712 · 2025-11-13T13:32:32Z

demo index.html

CanerKaraca23 · 2025-11-13T14:23:07Z

What about integrating all WebUI X features to KernelSU?

YuKongA

npm update #2928 --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

this is a squash of: * manager: introduce app package info API for webui-next (KernelSU-Next/KernelSU-Next@58167a4) * manager: sort a-z order for webui-next list packages api (KernelSU-Next/KernelSU-Next@4a9733c) * manager: implement getPackagesIcons and cacheAllPackageIcons api to webui-next (KernelSU-Next/KernelSU-Next@a361fa3) * manager/webui: let getPackagesIcons generate icon and store in cache as well when called (KernelSU-Next/KernelSU-Next@6afa86d) * POC: load icon app via ksu://icon/[packageName] (KernelSU-Next#674) (KernelSU-Next/KernelSU-Next@bc9927b) * manager: refine webui package manager (0400c42) Co-Authored-By: Rifat Azad <33044977+rifsxd@users.noreply.github.com> Co-Authored-By: Fahrez256Bit <167403685+fahrez256@users.noreply.github.com> Signed-off-by: KOWX712 <leecc0503@gmail.com> --------- Signed-off-by: KOWX712 <leecc0503@gmail.com> Co-authored-by: Rifat Azad <33044977+rifsxd@users.noreply.github.com> Co-authored-by: Fahrez256Bit <167403685+fahrez256@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

npm update tiann#2928 --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

- Supported since KernelSU v2.1.2 (tiann/KernelSU#2928)

CanerKaraca23 · 2025-11-29T01:54:29Z

@KOWX712 seems not working for me? Icons unavailable.

- Supported since KernelSU v2.1.2 (tiann/KernelSU#2928)

- sync with tiann/KernelSU#2928 Co-authored-by: Rifat Azad <33044977+rifsxd@users.noreply.github.com> Co-authored-by: Fahrez256Bit <167403685+fahrez256@users.noreply.github.com> Signed-off-by: KOWX712 <leecc0503@gmail.com>

* manager: introduce pm api in webui - sync with tiann/KernelSU#2928 Signed-off-by: KOWX712 <leecc0503@gmail.com> Co-authored-by: Rifat Azad <33044977+rifsxd@users.noreply.github.com> Co-authored-by: Fahrez256Bit <167403685+fahrez256@users.noreply.github.com>

ref: tiann/KernelSU#2928 Co-Authored-By: Rifat Azad <33044977+rifsxd@users.noreply.github.com> Co-Authored-By: Fahrez256Bit <167403685+fahrez256@users.noreply.github.com> Signed-off-by: KOWX712 <leecc0503@gmail.com>

* manager: introduce pm api in webui - sync with tiann/KernelSU#2928 Signed-off-by: KOWX712 <leecc0503@gmail.com> Co-authored-by: Rifat Azad <33044977+rifsxd@users.noreply.github.com> Co-authored-by: Fahrez256Bit <167403685+fahrez256@users.noreply.github.com>

ref: tiann/KernelSU#2928 Co-Authored-By: Rifat Azad <33044977+rifsxd@users.noreply.github.com> Co-Authored-By: Fahrez256Bit <167403685+fahrez256@users.noreply.github.com> Signed-off-by: KOWX712 <leecc0503@gmail.com>

this is a squash of: * manager: introduce app package info API for webui-next (KernelSU-Next/KernelSU-Next@58167a4) * manager: sort a-z order for webui-next list packages api (KernelSU-Next/KernelSU-Next@4a9733c) * manager: implement getPackagesIcons and cacheAllPackageIcons api to webui-next (KernelSU-Next/KernelSU-Next@a361fa3) * manager/webui: let getPackagesIcons generate icon and store in cache as well when called (KernelSU-Next/KernelSU-Next@6afa86d) * POC: load icon app via ksu://icon/[packageName] (KernelSU-Next#674) (KernelSU-Next/KernelSU-Next@bc9927b) * manager: refine webui package manager (KOWX712/KernelSU@0400c42) Co-Authored-By: Rifat Azad <33044977+rifsxd@users.noreply.github.com> Co-Authored-By: Fahrez256Bit <167403685+fahrez256@users.noreply.github.com> Co-authored-by: KOWX712 <leecc0503@gmail.com> --------- Co-authored-by: KOWX712 <leecc0503@gmail.com> Co-authored-by: Rifat Azad <33044977+rifsxd@users.noreply.github.com> Co-authored-by: Fahrez256Bit <167403685+fahrez256@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: u9521 <63995396+u9521@users.noreply.github.com>

npm update tiann#2928 --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

this is a squash of: * manager: introduce app package info API for webui-next (KernelSU-Next/KernelSU-Next@58167a4) * manager: sort a-z order for webui-next list packages api (KernelSU-Next/KernelSU-Next@4a9733c) * manager: implement getPackagesIcons and cacheAllPackageIcons api to webui-next (KernelSU-Next/KernelSU-Next@a361fa3) * manager/webui: let getPackagesIcons generate icon and store in cache as well when called (KernelSU-Next/KernelSU-Next@6afa86d) * POC: load icon app via ksu://icon/[packageName] (KernelSU-Next#674) (KernelSU-Next/KernelSU-Next@bc9927b) * manager: refine webui package manager (KOWX712/KernelSU@0400c42) Co-Authored-By: Rifat Azad <33044977+rifsxd@users.noreply.github.com> Co-Authored-By: Fahrez256Bit <167403685+fahrez256@users.noreply.github.com> Co-authored-by: KOWX712 <leecc0503@gmail.com> --------- Co-authored-by: KOWX712 <leecc0503@gmail.com> Co-authored-by: Rifat Azad <33044977+rifsxd@users.noreply.github.com> Co-authored-by: Fahrez256Bit <167403685+fahrez256@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: u9521 <63995396+u9521@users.noreply.github.com>

npm update tiann#2928 --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

ref: tiann/KernelSU#2928 Co-Authored-By: Rifat Azad <33044977+rifsxd@users.noreply.github.com> Co-Authored-By: Fahrez256Bit <167403685+fahrez256@users.noreply.github.com> Signed-off-by: KOWX712 <leecc0503@gmail.com>

KOWX712 and others added 2 commits November 13, 2025 14:05

merge all list packages funtion into listPackages

a30e2d6

tiann requested a review from Copilot November 13, 2025 12:30

Copilot started reviewing on behalf of tiann November 13, 2025 12:30 View session

Copilot finished reviewing on behalf of tiann November 13, 2025 12:33

Copilot AI reviewed Nov 13, 2025

View reviewed changes

KOWX712 and others added 6 commits November 13, 2025 20:39

Update manager/app/src/main/java/me/weishu/kernelsu/ui/webui/WebViewI…

d51d13e

…nterface.kt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

drop getPackagesIcons

e425502

Update manager/app/src/main/java/me/weishu/kernelsu/ui/webui/AppIconU…

e3670a2

…til.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

KOWX712 force-pushed the webui_pm branch from d93c5e5 to 8a8b2c6 Compare November 13, 2025 13:09

Update manager/app/src/main/java/me/weishu/kernelsu/ui/webui/AppIconU…

b383275

…til.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

KOWX712 marked this pull request as draft November 13, 2025 13:13

KOWX712 marked this pull request as ready for review November 13, 2025 13:20

Ylarod requested a review from YuKongA November 14, 2025 00:05

YuKongA approved these changes Nov 14, 2025

View reviewed changes

tiann merged commit 2ab6152 into tiann:main Nov 14, 2025
15 checks passed

KOWX712 deleted the webui_pm branch November 14, 2025 03:58

KOWX712 mentioned this pull request Nov 14, 2025

js: provide package manager function and documentation #2930

Merged

tiann pushed a commit that referenced this pull request Nov 14, 2025

js: provide package manager function and documentation (#2930)

ab3840a

npm update #2928 --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

KOWX712 added a commit to KOWX712/KernelSU that referenced this pull request Nov 14, 2025

js: provide package manager function and documentation (tiann#2930)

a18aed6

npm update tiann#2928 --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

KOWX712 added a commit to KOWX712/Tricky-Addon-Update-Target-List that referenced this pull request Nov 14, 2025

feat: add support for KernelSU new webui package manager api

1655e09

- Supported since KernelSU v2.1.2 (tiann/KernelSU#2928)

jpgjm mentioned this pull request Nov 19, 2025

[Feature]Supports new webui APIs. SukiSU-Ultra/SukiSU-Ultra#604

Closed

KOWX712 added a commit to KOWX712/Tricky-Addon-Update-Target-List that referenced this pull request Nov 24, 2025

feat: add support for KernelSU new webui package manager api

38ce91a

- Supported since KernelSU v2.1.2 (tiann/KernelSU#2928)

KOWX712 added a commit to KOWX712/Tricky-Addon-Update-Target-List that referenced this pull request Dec 6, 2025

feat: add support for KernelSU new webui package manager api

fe736f1

- Supported since KernelSU v2.1.2 (tiann/KernelSU#2928)

KOWX712 mentioned this pull request Dec 22, 2025

manager: introduce webui package manager api bmax121/APatch#1337

Merged

u9521 pushed a commit to u9521/KernelSU that referenced this pull request Jan 3, 2026

js: provide package manager function and documentation (tiann#2930)

6fa18bd

npm update tiann#2928 --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

u9521 pushed a commit to u9521/KernelSU that referenced this pull request Jan 5, 2026

js: provide package manager function and documentation (tiann#2930)

d102937

npm update tiann#2928 --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

manager: introduce webui package manager api#2928

manager: introduce webui package manager api#2928
tiann merged 9 commits into
tiann:mainfrom
KOWX712:webui_pm

KOWX712 commented Nov 13, 2025

Uh oh!

KOWX712 commented Nov 13, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KOWX712 commented Nov 13, 2025

Uh oh!

CanerKaraca23 commented Nov 13, 2025 •

edited

Loading

Uh oh!

YuKongA left a comment

Uh oh!

Uh oh!

CanerKaraca23 commented Nov 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

KOWX712 commented Nov 13, 2025

Uh oh!

KOWX712 commented Nov 13, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KOWX712 commented Nov 13, 2025

Uh oh!

CanerKaraca23 commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

YuKongA left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

CanerKaraca23 commented Nov 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CanerKaraca23 commented Nov 13, 2025 •

edited

Loading