Fix incorrect function names in non-GKI integration documentation#2722
Merged
Conversation
Contributor
Author
|
@Ylarod 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs. I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review. |
Co-authored-by: Ylarod <30978685+Ylarod@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [Documentation] Integration guide for non-GKI gets names for ksu_sucompat_init and ksu_ksud_init and wrong
Fix incorrect function names in non-GKI integration documentation
Aug 26, 2025
Ylarod
approved these changes
Aug 26, 2025
aviraxp
approved these changes
Oct 19, 2025
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Dec 31, 2025
…ann#2722) The integration guide for non-GKI devices incorrectly referenced function names when explaining how to test for broken KPROBES support. The documentation mentioned `ksu_enable_sucompat()` and `ksu_enable_ksud()`, but the actual function names in the kernel code are `ksu_sucompat_init()` and `ksu_ksud_init()`. This fix updates the function names in the troubleshooting tip across all language versions of the documentation: **Before:** ``` Comment out `ksu_enable_sucompat()` and `ksu_enable_ksud()` in `KernelSU/kernel/ksu.c` ``` **After:** ``` Comment out `ksu_sucompat_init()` and `ksu_ksud_init()` in `KernelSU/kernel/ksu.c` ``` The corrected function names match the actual declarations and calls found in `kernel/ksu.c`: ```c extern void ksu_sucompat_init(); extern void ksu_ksud_init(); ``` This documentation error could lead users to incorrectly attempt to comment out non-existent functions when troubleshooting bootloop issues with KernelSU integration. Fixes tiann#2701. <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Ylarod <30978685+Ylarod@users.noreply.github.com>
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 3, 2026
…ann#2722) The integration guide for non-GKI devices incorrectly referenced function names when explaining how to test for broken KPROBES support. The documentation mentioned `ksu_enable_sucompat()` and `ksu_enable_ksud()`, but the actual function names in the kernel code are `ksu_sucompat_init()` and `ksu_ksud_init()`. This fix updates the function names in the troubleshooting tip across all language versions of the documentation: **Before:** ``` Comment out `ksu_enable_sucompat()` and `ksu_enable_ksud()` in `KernelSU/kernel/ksu.c` ``` **After:** ``` Comment out `ksu_sucompat_init()` and `ksu_ksud_init()` in `KernelSU/kernel/ksu.c` ``` The corrected function names match the actual declarations and calls found in `kernel/ksu.c`: ```c extern void ksu_sucompat_init(); extern void ksu_ksud_init(); ``` This documentation error could lead users to incorrectly attempt to comment out non-existent functions when troubleshooting bootloop issues with KernelSU integration. Fixes tiann#2701. <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Ylarod <30978685+Ylarod@users.noreply.github.com>
u9521
pushed a commit
to u9521/KernelSU
that referenced
this pull request
Jan 5, 2026
…ann#2722) The integration guide for non-GKI devices incorrectly referenced function names when explaining how to test for broken KPROBES support. The documentation mentioned `ksu_enable_sucompat()` and `ksu_enable_ksud()`, but the actual function names in the kernel code are `ksu_sucompat_init()` and `ksu_ksud_init()`. This fix updates the function names in the troubleshooting tip across all language versions of the documentation: **Before:** ``` Comment out `ksu_enable_sucompat()` and `ksu_enable_ksud()` in `KernelSU/kernel/ksu.c` ``` **After:** ``` Comment out `ksu_sucompat_init()` and `ksu_ksud_init()` in `KernelSU/kernel/ksu.c` ``` The corrected function names match the actual declarations and calls found in `kernel/ksu.c`: ```c extern void ksu_sucompat_init(); extern void ksu_ksud_init(); ``` This documentation error could lead users to incorrectly attempt to comment out non-existent functions when troubleshooting bootloop issues with KernelSU integration. Fixes tiann#2701. <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Ylarod <30978685+Ylarod@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integration guide for non-GKI devices incorrectly referenced function names when explaining how to test for broken KPROBES support. The documentation mentioned
ksu_enable_sucompat()andksu_enable_ksud(), but the actual function names in the kernel code areksu_sucompat_init()andksu_ksud_init().This fix updates the function names in the troubleshooting tip across all language versions of the documentation:
Before:
After:
The corrected function names match the actual declarations and calls found in
kernel/ksu.c:This documentation error could lead users to incorrectly attempt to comment out non-existent functions when troubleshooting bootloop issues with KernelSU integration.
Fixes #2701.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.