Skip to content

🌐 Update Urdu translation for docs/ur/docs/benchmarks.md#10046

Merged
tiangolo merged 21 commits intofastapi:masterfrom
AhsanSheraz:add-urdu-translation-external-link-page
Aug 17, 2024
Merged

🌐 Update Urdu translation for docs/ur/docs/benchmarks.md#10046
tiangolo merged 21 commits intofastapi:masterfrom
AhsanSheraz:add-urdu-translation-external-link-page

Conversation

@AhsanSheraz
Copy link
Copy Markdown
Contributor

No description provided.

@tiangolo
Copy link
Copy Markdown
Member

tiangolo commented Aug 8, 2023

📝 Docs preview for commit b0efbaa at: https://3fc208db.fastapitiangolo.pages.dev

@tiangolo
Copy link
Copy Markdown
Member

tiangolo commented Aug 8, 2023

📝 Docs preview for commit 641e549 at: https://8aa88612.fastapitiangolo.pages.dev

@tiangolo
Copy link
Copy Markdown
Member

tiangolo commented Aug 8, 2023

📝 Docs preview for commit 1fa9c0e at: https://4b86ca05.fastapitiangolo.pages.dev

@tiangolo
Copy link
Copy Markdown
Member

tiangolo commented Aug 8, 2023

📝 Docs preview for commit eaf69c8 at: https://c1c699fb.fastapitiangolo.pages.dev

@AhsanSheraz AhsanSheraz changed the title Add Urdu translation for docs/ur/docs/external-links.md and fix urdu issue in Add Urdu translation for docs/ur/docs/benchmarks.md` 🌐 Add Urdu translation for docs/ur/docs/external-links.md and fix urdu issue in Add Urdu translation for docs/ur/docs/benchmarks.md` Aug 8, 2023
@AhsanSheraz AhsanSheraz changed the title 🌐 Add Urdu translation for docs/ur/docs/external-links.md and fix urdu issue in Add Urdu translation for docs/ur/docs/benchmarks.md` 🌐 Add Urdu translation for docs/ur/docs/external-links.md and fix urdu issue in Add Urdu translation for docs/ur/docs/benchmarks.md Aug 8, 2023
@talhaumer
Copy link
Copy Markdown

Looks Good

@AhsanSheraz
Copy link
Copy Markdown
Contributor Author

@tiangolo Can you please add labels to this MR?

@tiangolo tiangolo added lang-all Translations awaiting-review lang-ur Urdu translations labels Aug 14, 2023
Copy link
Copy Markdown

@talhaumer talhaumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@talhaumer
Copy link
Copy Markdown

Looks good

Copy link
Copy Markdown

@talhaumer talhaumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Copy Markdown

@talha-softversum talha-softversum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

Copy link
Copy Markdown

@talhaumer talhaumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking Good

@tiangolo
Copy link
Copy Markdown
Member

📝 Docs preview for commit 6929a70 at: https://86521267.fastapitiangolo.pages.dev

@AhsanSheraz
Copy link
Copy Markdown
Contributor Author

AhsanSheraz commented Oct 29, 2023

@tiangolo everything is working well but we have to add this

style="text-align: right;"

because it is aligning to the left but it should be to the right, so adding this as well.
image

Now you see after adding the style text-align right make it like the below:
image

@tiangolo
Copy link
Copy Markdown
Member

📝 Docs preview for commit 2b1c774 at: https://5ff66add.fastapitiangolo.pages.dev

@alejsdev alejsdev added p2 and removed investigate labels Jan 15, 2024
@tiangolo
Copy link
Copy Markdown
Member

I just noticed that there was another CSS bug introduced by a previous RTL PR, I just fixed it here: #11039

Now with this, you can remove all the style="text-align: right;" blocks. 🤓

@tiangolo tiangolo added p4 and removed p2 labels Jan 28, 2024
@tiangolo
Copy link
Copy Markdown
Member

📝 Docs preview for commit 6cebf05 at: https://05a3595f.fastapitiangolo.pages.dev

@tiangolo
Copy link
Copy Markdown
Member

tiangolo commented Feb 4, 2024

📝 Docs preview for commit 82a9dd4 at: https://1e425d33.fastapitiangolo.pages.dev

@tiangolo
Copy link
Copy Markdown
Member

tiangolo commented Feb 4, 2024

📝 Docs preview for commit 6c9362e at: https://28dd6e57.fastapitiangolo.pages.dev

Copy link
Copy Markdown
Contributor Author

@AhsanSheraz AhsanSheraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed all the changes in this MR

@AhsanSheraz
Copy link
Copy Markdown
Contributor Author

I just noticed that there was another CSS bug introduced by a previous RTL PR, I just fixed it here: #11039

Now with this, you can remove all the style="text-align: right;" blocks. 🤓

@tiangolo Fixed all the changes in this MR related to `style="text-align: right;" divs and removed this from all the files.

Copy link
Copy Markdown

@aimasheraz1 aimasheraz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now without style and div

@tiangolo tiangolo changed the title 🌐 Add Urdu translation for docs/ur/docs/external-links.md and fix urdu issue in Add Urdu translation for docs/ur/docs/benchmarks.md 🌐 Update Urdu translation for docs/ur/docs/benchmarks.md Aug 17, 2024
@tiangolo
Copy link
Copy Markdown
Member

Thank you! 🤓

We are no longer translating some specific pages: https://fastapi.tiangolo.com/contributing/#dont-translate-these-pages

So I updated it to include the updated page that would go in. Thanks! 🍰

@tiangolo tiangolo removed the p4 label Aug 17, 2024
@tiangolo tiangolo enabled auto-merge (squash) August 17, 2024 06:39
@tiangolo tiangolo merged commit ff1118d into fastapi:master Aug 17, 2024
black-redoc pushed a commit to black-redoc/fastapi that referenced this pull request Aug 17, 2024
…0046)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
black-redoc pushed a commit to black-redoc/fastapi that referenced this pull request Sep 12, 2024
…0046)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
s-rigaud pushed a commit to s-rigaud/fastapi that referenced this pull request Jan 23, 2025
…0046)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Sebastián Ramírez <tiangolo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved-2 lang-all Translations lang-ur Urdu translations

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants