Skip to content

Remove Rails 6.0.z support#1548

Merged
vsppedro merged 2 commits intothoughtbot:mainfrom
HeitorMC:refactor/remove-rails-6-0-z
Apr 3, 2023
Merged

Remove Rails 6.0.z support#1548
vsppedro merged 2 commits intothoughtbot:mainfrom
HeitorMC:refactor/remove-rails-6-0-z

Conversation

@HeitorMC
Copy link
Copy Markdown
Contributor

@HeitorMC HeitorMC commented Mar 23, 2023

Removes Rails 6.0.z support due to EOL.

@mcmire
Copy link
Copy Markdown
Collaborator

mcmire commented Mar 23, 2023

@HeitorMC Thanks for this. Would you mind updating the "Compatibility" section of the README? I think it references Rails 5.2+ as being supported.

Also, since this PR also removes Rails 5.2 in addition to 6.0.x, do you mind updating the PR title to include that information?

@HeitorMC
Copy link
Copy Markdown
Contributor Author

HeitorMC commented Mar 23, 2023

@HeitorMC Thanks for this. Would you mind updating the "Compatibility" section of the README? I think it references Rails 5.2+ as being supported.

Sure!

Also, since this PR removes Rails 5.2 in addition to 6.0.x, do you mind updating the PR title to include that information?

Ohh, my bad. I did this because this #1522 wasn't merged yet. So I added Douglas's changes into my pr, then, once his pr gets merged, mine PR won't have conflicts. I don't know if this was the best approach. Please let me know so that I can fix the changes 😄

@mcmire
Copy link
Copy Markdown
Collaborator

mcmire commented Mar 24, 2023 •
edited
Loading

@HeitorMC Ah, right. That makes sense! Yeah we can definitely work on merging #1522 first.

@HeitorMC
Copy link
Copy Markdown
Contributor Author

HeitorMC commented Mar 29, 2023

Hey, @mcmire @vsppedro any updates on this case?

mcmire
mcmire reviewed Mar 29, 2023
View reviewed changes
Comment thread README.md Outdated
* [Team](#team)
* [Copyright/License](#copyright-license)
* [About thoughtbot](#about-thoughtbot)
- [Getting started](#getting-started)
Copy link
Copy Markdown
Collaborator

@mcmire mcmire Mar 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the formatting changes to the README necessary in this PR or can we do this in a different PR? Is there something that forced this change?

Copy link
Copy Markdown
Contributor Author

@HeitorMC HeitorMC Mar 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, my bad. It was the linter 😅 Lemme fix it

vsppedro
vsppedro reviewed Mar 29, 2023
View reviewed changes
Comment thread README.md Outdated
@HeitorMC HeitorMC force-pushed the refactor/remove-rails-6-0-z branch from 7d0cb63 to 1abed79 Compare March 29, 2023 19:32
@vsppedro
Copy link
Copy Markdown
Collaborator

vsppedro commented Mar 29, 2023

Hi, @HeitorMC, LGTM! We only need to fix the conflict.

@HeitorMC HeitorMC force-pushed the refactor/remove-rails-6-0-z branch from 1abed79 to d0230fb Compare March 30, 2023 01:32
@HeitorMC
Copy link
Copy Markdown
Contributor Author

HeitorMC commented Apr 3, 2023

Hi, @HeitorMC, LGTM! We only need to fix the conflict.

Done 👍

@vsppedro vsppedro merged commit ff8db74 into thoughtbot:main Apr 3, 2023
@vsppedro vsppedro mentioned this pull request Apr 4, 2023
Merged
@vsppedro vsppedro mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcmire mcmire mcmire left review comments

@vsppedro vsppedro vsppedro left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HeitorMC @mcmire @vsppedro