Skip to content

Remove Rails 5.2 support#1522

Merged
vsppedro merged 1 commit intothoughtbot:mainfrom
dougmrqs:remove-rails-5-2
Mar 29, 2023
Merged

Remove Rails 5.2 support#1522
vsppedro merged 1 commit intothoughtbot:mainfrom
dougmrqs:remove-rails-5-2

Conversation

@dougmrqs
Copy link
Copy Markdown
Contributor

Removes Rails 5.2 support due to EOL.

Referent to #1513

@vsppedro vsppedro added this to the 6.0.0 milestone Nov 21, 2022
@vsppedro
Copy link
Copy Markdown
Collaborator

Hi again, @dougmrqs, would be possible to fix the conflicts in this PR? Thanks for this contribution.

@HeitorMC
Copy link
Copy Markdown
Contributor

HeitorMC commented Mar 22, 2023

Hi again, @dougmrqs, would be possible to fix the conflicts in this PR? Thanks for this contribution.

Hey @vsppedro, I talked with @dougmrqs and fixed this small conflict for him 🤝

@vsppedro
Copy link
Copy Markdown
Collaborator

Nice! Thanks again for working on this!

@HeitorMC
Copy link
Copy Markdown
Contributor

HeitorMC commented Mar 22, 2023

Hey @vsppedro, I received one e-mail saying:

I'll put both of you guys as co-authored in the squash commit. Is that okay?

Yeah, I talked again with Douglas and he's okay with that 👍

Comment thread .github/workflows/ci.yml
Copy link
Copy Markdown
Collaborator

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vsppedro vsppedro merged commit 7f836b7 into thoughtbot:main Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants