Skip to content

fix: Avoid spurious unknown pkid warning on bridge healthcheck#3821

Merged
jarhodes314 merged 2 commits intothin-edge:mainfrom
jarhodes314:fix/bridge-unknown-pkid-warning
Oct 16, 2025
Merged

fix: Avoid spurious unknown pkid warning on bridge healthcheck#3821
jarhodes314 merged 2 commits intothin-edge:mainfrom
jarhodes314:fix/bridge-unknown-pkid-warning

Conversation

@jarhodes314
Copy link
Copy Markdown
Contributor

Proposed changes

Prior to these changes, whenever it runs, the built-in bridge produces two warnings like this:

2025-10-15T13:40:55.752977Z  WARN MQTT bridge: [local] Received ack for unknown pkid=2

This is caused by the healthcheck message, which we ignore in the ack processing as we don't need to forward the acknowledgement to the other broker like we do for forwarded messages. Since this case isn't actually the bridge or broker misbehaving, this PR prevents the bridge warning when it receives the ack for the healthcheck message.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@jarhodes314 jarhodes314 added the theme:bridge Built-in (Rust) bridge topics label Oct 15, 2025
@jarhodes314 jarhodes314 force-pushed the fix/bridge-unknown-pkid-warning branch from 6fdf3ff to 2738e8d Compare October 15, 2025 13:47
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 15, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
713 0 3 713 100 2h15m23.239480999s

Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Thank you for taking care of what could be seen as a detail, but actually improve the confidence we can have on thin-edge.

@jarhodes314 jarhodes314 added this pull request to the merge queue Oct 16, 2025
github-merge-queue bot pushed a commit that referenced this pull request Oct 16, 2025
…ning

fix: Avoid spurious unknown pkid warning on bridge healthcheck
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 16, 2025
@jarhodes314 jarhodes314 force-pushed the fix/bridge-unknown-pkid-warning branch from 2738e8d to 6d2081b Compare October 16, 2025 16:12
@jarhodes314 jarhodes314 enabled auto-merge October 16, 2025 16:12
@jarhodes314 jarhodes314 added this pull request to the merge queue Oct 16, 2025
Merged via the queue into thin-edge:main with commit 7947d59 Oct 16, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:bridge Built-in (Rust) bridge topics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants