fix: Avoid spurious unknown pkid warning on bridge healthcheck#3821
Merged
jarhodes314 merged 2 commits intothin-edge:mainfrom Oct 16, 2025
Merged
Conversation
6fdf3ff to
2738e8d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Contributor
Robot Results
|
didier-wenzek
approved these changes
Oct 16, 2025
Contributor
didier-wenzek
left a comment
There was a problem hiding this comment.
Approved. Thank you for taking care of what could be seen as a detail, but actually improve the confidence we can have on thin-edge.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
…ning fix: Avoid spurious unknown pkid warning on bridge healthcheck
Signed-off-by: James Rhodes <jarhodes314@gmail.com>
2738e8d to
6d2081b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Prior to these changes, whenever it runs, the built-in bridge produces two warnings like this:
This is caused by the healthcheck message, which we ignore in the ack processing as we don't need to forward the acknowledgement to the other broker like we do for forwarded messages. Since this case isn't actually the bridge or broker misbehaving, this PR prevents the bridge warning when it receives the ack for the healthcheck message.
Types of changes
Paste Link to the issue
Checklist
just prepare-devonce)just formatas mentioned in CODING_GUIDELINESjust checkas mentioned in CODING_GUIDELINESFurther comments