Skip to content

refactor: assume 443 as the default https proxy port#3808

Merged
reubenmiller merged 1 commit intothin-edge:mainfrom
jarhodes314:fix/https-default-port-proxy
Oct 7, 2025
Merged

refactor: assume 443 as the default https proxy port#3808
reubenmiller merged 1 commit intothin-edge:mainfrom
jarhodes314:fix/https-default-port-proxy

Conversation

@jarhodes314
Copy link
Copy Markdown
Contributor

@jarhodes314 jarhodes314 commented Oct 6, 2025

Proposed changes

Following #3804 which allows the user to not specify a proxy port, this PR refactors the proxy URL parsing to use 443 rather than 80 as the default port when specifying https as the scheme with no explicit port.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 6, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 98.43750% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...on/tedge_config/src/tedge_toml/models/proxy_url.rs 98.43% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reubenmiller reubenmiller added the theme:connectivity Generic connectivity related stuff like HTTP proxy etc. label Oct 6, 2025
@jarhodes314
fix: assume 443 as the default https proxy port
da7809c 
Signed-off-by: James Rhodes <jarhodes314@gmail.com>
@jarhodes314 jarhodes314 force-pushed the fix/https-default-port-proxy branch from 27b835d to da7809c Compare October 6, 2025 13:32
@jarhodes314 jarhodes314 temporarily deployed to Test Pull Request October 6, 2025 13:32 — with GitHub Actions Inactive
reubenmiller
reubenmiller approved these changes Oct 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Nice refactoring to make the parsing a lot clearer

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 6, 2025 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
709 0 3 709 100 2h4m14.508935s

didier-wenzek
didier-wenzek approved these changes Oct 7, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller added this pull request to the merge queue Oct 7, 2025
Merged via the queue into thin-edge:main with commit 8310f02 Oct 7, 2025
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reubenmiller reubenmiller reubenmiller approved these changes

@didier-wenzek didier-wenzek didier-wenzek approved these changes

@albinsuresh albinsuresh Awaiting requested review from albinsuresh albinsuresh is a code owner

@rina23q rina23q Awaiting requested review from rina23q rina23q is a code owner

Assignees

No one assigned

Labels

theme:connectivity Generic connectivity related stuff like HTTP proxy etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jarhodes314 @reubenmiller @didier-wenzek