Skip to content

fix: proxy port parsing issue when using port 80#3804

Merged
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:fix-proxy-port-parsing
Oct 6, 2025
Merged

fix: proxy port parsing issue when using port 80#3804
reubenmiller merged 1 commit intothin-edge:mainfrom
reubenmiller:fix-proxy-port-parsing

Conversation

@reubenmiller
Copy link
Copy Markdown
Contributor

Proposed changes

Fix a bug when using port 80 within theproxy.address setting.

The parsing issue was caused by howUrl::parse() parses well known ports like 80.

Below shows the bug which is now resolved by switching to using .port_or_known_default() instead of .port().

# tedge config set proxy.address 'https://127.0.0.1:80'
Error: failed to set the configuration key: 'proxy.address' with value: https://127.0.0.1:80.

Caused by:
    0: Failed to parse input
    1: Invalid proxy URL: 127.0.0.1:80 is missing a port
    2: 127.0.0.1:80 is missing a port

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#3803

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller reubenmiller added the theme:connectivity Generic connectivity related stuff like HTTP proxy etc. label Oct 5, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 5, 2025

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
709 0 3 709 100 2h10m49.700875s

Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Signed-off-by: reubenmiller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller force-pushed the fix-proxy-port-parsing branch from f4ad77e to 1bfa0cc Compare October 6, 2025 11:32
@reubenmiller reubenmiller enabled auto-merge October 6, 2025 11:34
@reubenmiller reubenmiller added this pull request to the merge queue Oct 6, 2025
Merged via the queue into thin-edge:main with commit d22363f Oct 6, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

theme:connectivity Generic connectivity related stuff like HTTP proxy etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants