Skip to content

chore: bump MSRV to 1.85#3735

Merged
didier-wenzek merged 3 commits intothin-edge:mainfrom
didier-wenzek:chore/bump-msrv-1.85
Jul 22, 2025
Merged

chore: bump MSRV to 1.85#3735
didier-wenzek merged 3 commits intothin-edge:mainfrom
didier-wenzek:chore/bump-msrv-1.85

Conversation

@didier-wenzek
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek commented Jul 18, 2025

Proposed changes

Bump MSRV to 1.85. This is notably required for the quickJs dependency of the extensible mapper.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@didier-wenzek didier-wenzek added the ci/cd Repository management and pipeline topics label Jul 18, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@didier-wenzek
Copy link
Copy Markdown
Contributor Author

didier-wenzek commented Jul 18, 2025

Oops, the CI has to be updated first: #3736

@didier-wenzek
Bump MSRV to 1.85
6d44e00 
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
@didier-wenzek
Clippy fix: map_or(true,cond) -> is_none_or(cond)
ad223f0 
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
@didier-wenzek didier-wenzek force-pushed the chore/bump-msrv-1.85 branch from e3da368 to ad223f0 Compare July 22, 2025 13:02
@didier-wenzek didier-wenzek temporarily deployed to Test Pull Request July 22, 2025 13:02 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 22, 2025 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
666 0 3 666 100 1h49m18.061868999s

@didier-wenzek didier-wenzek temporarily deployed to Test Pull Request July 22, 2025 14:17 — with GitHub Actions Inactive
@didier-wenzek
Clippy fix: repeat(x).take(n) -> repeat_n(x,n)
b4541e2 
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
@didier-wenzek didier-wenzek force-pushed the chore/bump-msrv-1.85 branch from ef39976 to b4541e2 Compare July 22, 2025 15:13
@didier-wenzek didier-wenzek temporarily deployed to Test Pull Request July 22, 2025 15:13 — with GitHub Actions Inactive
@didier-wenzek didier-wenzek added this pull request to the merge queue Jul 22, 2025
Merged via the queue into thin-edge:main with commit c7393ff Jul 22, 2025
49 of 50 checks passed
@didier-wenzek didier-wenzek deleted the chore/bump-msrv-1.85 branch July 22, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bravo555 Bravo555 Bravo555 approved these changes

@jarhodes314 jarhodes314 jarhodes314 approved these changes

@reubenmiller reubenmiller Awaiting requested review from reubenmiller reubenmiller is a code owner

@albinsuresh albinsuresh Awaiting requested review from albinsuresh albinsuresh is a code owner

@rina23q rina23q Awaiting requested review from rina23q rina23q is a code owner

Assignees

No one assigned

Labels

ci/cd Repository management and pipeline topics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@didier-wenzek @Bravo555 @jarhodes314