Skip to content

chore: bump CI MSRV to 1.85#3736

Merged
didier-wenzek merged 1 commit intothin-edge:mainfrom
didier-wenzek:chore/bump-ci-msrv-1.85
Jul 22, 2025
Merged

chore: bump CI MSRV to 1.85#3736
didier-wenzek merged 1 commit intothin-edge:mainfrom
didier-wenzek:chore/bump-ci-msrv-1.85

Conversation

@didier-wenzek
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek commented Jul 18, 2025

Proposed changes

Bump the MSRV used by github actions.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@didier-wenzek didier-wenzek temporarily deployed to Test Pull Request July 18, 2025 08:20 — with GitHub Actions Inactive
@didier-wenzek didier-wenzek mentioned this pull request Jul 18, 2025
Merged
11 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 18, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 18, 2025 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
666 0 3 666 100 1h49m38.225492999s

@didier-wenzek didier-wenzek added the ci/cd Repository management and pipeline topics label Jul 18, 2025
rina23q
rina23q approved these changes Jul 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Bravo555
Bravo555 approved these changes Jul 21, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Bravo555 Bravo555 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed looks like 1.85.1 is the latest version supported by Yocto, so approving.

@didier-wenzek
Bump CI MSRV to 1.85
e55d84f 
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
@didier-wenzek didier-wenzek force-pushed the chore/bump-ci-msrv-1.85 branch from afca974 to e55d84f Compare July 22, 2025 11:25
@didier-wenzek didier-wenzek temporarily deployed to Test Pull Request July 22, 2025 11:25 — with GitHub Actions Inactive
@didier-wenzek didier-wenzek enabled auto-merge July 22, 2025 11:26
@didier-wenzek didier-wenzek added this pull request to the merge queue Jul 22, 2025
Merged via the queue into thin-edge:main with commit 66af4ca Jul 22, 2025
51 of 52 checks passed
@didier-wenzek didier-wenzek deleted the chore/bump-ci-msrv-1.85 branch July 22, 2025 12:58
@reubenmiller reubenmiller added the skip-release-notes Don't include the ticket in the auto generated release notes label Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bravo555 Bravo555 Bravo555 approved these changes

@rina23q rina23q rina23q approved these changes

@reubenmiller reubenmiller Awaiting requested review from reubenmiller reubenmiller is a code owner

Assignees

No one assigned

Labels

ci/cd Repository management and pipeline topics skip-release-notes Don't include the ticket in the auto generated release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@didier-wenzek @Bravo555 @rina23q @reubenmiller