Skip to content

refactor: Revert "disable problematic tests to allow the CI changes to be merged"#3727

Merged
jarhodes314 merged 1 commit intothin-edge:mainfrom
jarhodes314:test/reenable-download
Jul 11, 2025
Merged

refactor: Revert "disable problematic tests to allow the CI changes to be merged"#3727
jarhodes314 merged 1 commit intothin-edge:mainfrom
jarhodes314:test/reenable-download

Conversation

@jarhodes314
Copy link
Copy Markdown
Contributor

@jarhodes314 jarhodes314 commented Jul 10, 2025

This reverts commit dd5a8e0.

Proposed changes

Re-enable the download tests following the merging of #3726.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s. You can activate automatic signing by running just prepare-dev once)
  • I ran just format as mentioned in CODING_GUIDELINES
  • I used just check as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@jarhodes314 jarhodes314 added the ci/cd Repository management and pipeline topics label Jul 10, 2025
@jarhodes314 jarhodes314 temporarily deployed to Test Pull Request July 10, 2025 16:25 — with GitHub Actions Inactive
didier-wenzek
didier-wenzek approved these changes Jul 10, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jul 10, 2025 •
edited
Loading

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
654 0 3 654 100 1h51m5.728589999s

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@didier-wenzek didier-wenzek mentioned this pull request Jul 11, 2025
Merged
11 tasks
@jarhodes314 jarhodes314 force-pushed the test/reenable-download branch from dba3c9c to 987aa9d Compare July 11, 2025 14:24
@jarhodes314 jarhodes314 temporarily deployed to Test Pull Request July 11, 2025 14:24 — with GitHub Actions Inactive
@jarhodes314 jarhodes314 enabled auto-merge July 11, 2025 14:25
@jarhodes314 jarhodes314 added this pull request to the merge queue Jul 11, 2025
Merged via the queue into thin-edge:main with commit 0c6b456 Jul 11, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@didier-wenzek didier-wenzek didier-wenzek approved these changes

@albinsuresh albinsuresh Awaiting requested review from albinsuresh albinsuresh is a code owner

@rina23q rina23q Awaiting requested review from rina23q rina23q is a code owner

Assignees

No one assigned

Labels

ci/cd Repository management and pipeline topics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jarhodes314 @didier-wenzek