refactor: run tests in CI with different temporary directory#3726
Merged
jarhodes314 merged 2 commits intothin-edge:mainfrom Jul 10, 2025
Merged
refactor: run tests in CI with different temporary directory#3726jarhodes314 merged 2 commits intothin-edge:mainfrom
jarhodes314 merged 2 commits intothin-edge:mainfrom
Conversation
Signed-off-by: James Rhodes <jarhodes314@gmail.com>
Contributor
Robot Results
|
Signed-off-by: James Rhodes <jarhodes314@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This was referenced Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
In order to get the unit tests running successfully on #3717, we need the download tests to have more disk space available. They are currently failing since they require the disk to have at least 5% free disk space in order for them to start a download.
These changes change the directory for the temporary files in the unit tests to be a subdirectory of
/mnt, which is a separate disk on the github actions runner. This should mean that the tests don't fail due toInsufficientSpaceintedge_downloader_extand therefore #3717 can be merged.Types of changes
Paste Link to the issue
Checklist
just prepare-devonce)just formatas mentioned in CODING_GUIDELINESjust checkas mentioned in CODING_GUIDELINESFurther comments