fix: Include name in tedge service registration message#3592
Merged
albinsuresh merged 1 commit intothin-edge:mainfrom May 5, 2025
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
Contributor
Robot Results
|
didier-wenzek
approved these changes
May 5, 2025
Contributor
There was a problem hiding this comment.
Approved. The misleading error messages are correctly removed.
However we need to look for a longer term solution. See this comment #3591
rina23q
approved these changes
May 5, 2025
bd0fd78 to
6538442
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Include
namein tedge service registration message, along withtypethat already existed. This prevents the any auto-registration messages generated for the same service, with thenamefragment, from conflicting with their initial explicit registration message.Types of changes
Paste Link to the issue
#3591
Checklist
just prepare-devonce)just formatas mentioned in CODING_GUIDELINESjust checkas mentioned in CODING_GUIDELINESFurther comments