feat: add filtering to tedge config list#3264
Merged
jarhodes314 merged 1 commit intothin-edge:mainfrom Nov 29, 2024
Merged
Conversation
Signed-off-by: James Rhodes <jarhodes314@gmail.com>
69eb845 to
7066d85
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files📢 Thoughts on this report? Let us know! |
Contributor
Robot Results
|
albinsuresh
approved these changes
Nov 27, 2024
Contributor
albinsuresh
left a comment
There was a problem hiding this comment.
LGTM. Initially I was wondering if the filter value should have been behind a --filter option or something like that. But, the proposed usage also looks quite natural.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 29, 2024
feat: add filtering to `tedge config list`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
This adds an optional argument to
tedge config listandtedge config list --docwhich filters the list of configuration keys shown, since the complete list is now very large.For example:
$ ./tedge config list --doc agent agent.state.path The directory where the tedge-agent persists its state across restarts. Note: If the given directory doesn't exists, `/etc/tedge/.agent` is used as a fallback irrespective of the current setting. Example: /data/tedge/agent agent.enable.config_update Determines if tedge-agent should enable config_update operation. Example: true agent.enable.config_snapshot Determines if tedge-agent should enable config_snapshot operation. Example: true agent.enable.log_upload Determines if tedge-agent should enable log_upload operation. Example: trueIt uses a substring match, so it is easy to search for http related properties or certificate paths:
Types of changes
Paste Link to the issue
Checklist
cargo fmtas mentioned in CODING_GUIDELINEScargo clippyas mentioned in CODING_GUIDELINESFurther comments