Merged
Conversation
After creating keys in a new repository, repo.Clean would remove the staged root.json, rendering the keys unusable. Given Clean is only useful to reset the state to what is committed, it only makes sense to call it when something has been committed already, so this change prevents cleaning a new repository. Signed-off-by: Lewis Marshall <lewis@lmars.net>
Contributor
|
LGTM |
lmars
added a commit
that referenced
this pull request
Mar 26, 2015
repo: Prevent cleaning a new repository
rdimitrov
pushed a commit
to rdimitrov/go-tuf
that referenced
this pull request
Jan 25, 2024
…eframework#81) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.15.0. - [Commits](golang/crypto@v0.14.0...v0.15.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
rdimitrov
pushed a commit
that referenced
this pull request
Jan 29, 2024
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.15.0. - [Commits](golang/crypto@v0.14.0...v0.15.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After creating keys in a new repository,
repo.Clean()would remove the stagedroot.json, rendering the keys unusable.Given
Cleanis only useful to reset the state to what is committed, it only makes sense to call it when something has been committed already, so this change prevents cleaning a new repository.Fixes #78.