Skip to content

Conversation

@maflcko
Copy link

@maflcko maflcko commented Sep 13, 2015

I remember people were requesting to add this to the readme.

@jonasschnelli
Copy link

ACK.
One thought: would it make sense to move the repository from theuni to bitcoin/bitcoin-trivial? Or is this not even possible with github?

@maflcko
Copy link
Author

maflcko commented Sep 13, 2015

Would work in theory, but it's a fork from the bitcoin repo so I guess it needs to be "unforked" first.

@maflcko
Copy link
Author

maflcko commented Sep 26, 2015

@theuni I am closing this because bitcoin#6718 got merged. If you merged this, there'd be yet another conflict when merging your trivial branch to bitcoin/master.

@maflcko maflcko closed this Sep 26, 2015
@maflcko maflcko deleted the patch-1 branch September 26, 2015 09:02
theuni pushed a commit that referenced this pull request Nov 20, 2020
6954156 qt: Fix visual quality of text in QR image (Hennadii Stepanov)
8071c75 qt, refactor: Limit scope of QPainter object (Hennadii Stepanov)

Pull request description:

  Master (197450f):
  ![DeepinScreenshot_select-area_20200824001800](https://user-images.githubusercontent.com/32963518/90988962-96283680-e59f-11ea-8e20-42e9b23033f5.png)

  This PR (6954156):
  - macOS 10.15.6
  ![Screenshot from 2020-09-07 15-40-30](https://user-images.githubusercontent.com/32963518/92390251-2c716600-f123-11ea-96f0-0e9d35810c76.png)

  - Linux Mint 20
  ![Screenshot from 2020-09-07 15-48-13](https://user-images.githubusercontent.com/32963518/92390272-36936480-f123-11ea-8fee-4de23bb40ed9.png)

  Fix #54
  Fix bitcoin#19103

  ---

  The first commit is easy to review with [`git diff --word-diff`](bitcoin-core/gui@8071c75?w=1).

ACKs for top commit:
  jonasschnelli:
    Tested ACK 6954156 - tested on macOS 10.15. Fixes the problem.

Tree-SHA512: 6ecb3397d2a5094c5f00ee05fc09520751568404e000a8691b6de7e57f38c2d5da628694e5e45a2b4cc302a846bbc00014c40820233eb026d3ebd4f68c2c9913
theuni pushed a commit that referenced this pull request Aug 22, 2025
efb8ea04e4 Merge bitcoin-core/crc32c-subtree#8: Sync to upstream
4a7a05c48d Merge remote-tracking branch 'google/main' into bitcoin-fork
21fc8ef304 Fix typo (bitcoin#59)
89f69843a1 Fix misspelled "Proccess" in comment
02e65f4fd3 Bump deps (#56)
b9d6e825a1 Fix Windows CI build. (#54)
bbbb93ab5d Switch CI to GitHub Actions (#55)
d46cd17d70 Add clangd cache directory to .gitignore.

git-subtree-dir: src/crc32c
git-subtree-split: efb8ea04e4a5b6a18dc4bc1908fd1cb2dcefb585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants