Skip to content

topology2: Add support for cs42l43 SKU with four host DMICs#9666

Merged
lgirdwood merged 1 commit intothesofproject:mainfrom
CirrusLogic:sof-lnl-cs42l43-l0-4ch
Nov 21, 2024
Merged

topology2: Add support for cs42l43 SKU with four host DMICs#9666
lgirdwood merged 1 commit intothesofproject:mainfrom
CirrusLogic:sof-lnl-cs42l43-l0-4ch

Conversation

@simontrimmer
Copy link
Contributor

@simontrimmer simontrimmer commented Nov 19, 2024 •
edited
Loading

Add support for another Lenovo SKU that uses cs42l43 and four host side DMICs rather than the CODECs DMICs.

@simontrimmer simontrimmer force-pushed the sof-lnl-cs42l43-l0-4ch branch from 7723f41 to dc937fb Compare November 19, 2024 12:10
@simontrimmer simontrimmer mentioned this pull request Nov 19, 2024
Closed
@lgirdwood
Copy link
Member

lgirdwood commented Nov 19, 2024

@bardliao pls review.

@bardliao
Copy link
Collaborator

bardliao commented Nov 19, 2024

The main question is that is the SoundWire DMIC used or not. If not, we need to add a quirk in the machine driver. Like Remove CODEC DMIC for specific SKUs by charleskeepax · Pull Request #5186 · thesofproject/linux And, 'SDW_DMIC_STREAM=Capture-SmartMic' is not needed in that case.
If the SoundWire DMIC and the host DMIC coexist, we need to add SDW_DMIC=1

@simontrimmer simontrimmer force-pushed the sof-lnl-cs42l43-l0-4ch branch from dc937fb to 41e90a0 Compare November 19, 2024 16:16
@simontrimmer
Copy link
Contributor Author

simontrimmer commented Nov 19, 2024

@charleskeepax - I've been having some fun with this today, I'll bother you about it more tomorrow

@simontrimmer
Copy link
Contributor Author

simontrimmer commented Nov 19, 2024

Hey @bardliao

The main question is that is the SoundWire DMIC used or not. If not, we need to add a quirk in the machine driver. Like Remove CODEC DMIC for specific SKUs by charleskeepax · Pull Request #5186 · thesofproject/linux And, 'SDW_DMIC_STREAM=Capture-SmartMic' is not needed in that case. If the SoundWire DMIC and the host DMIC coexist, we need to add SDW_DMIC=1

I'm pretty certain that we don't have the SoundWire DMIC so will be adding the SOC_SDW_CODEC_MIC quirk when updating the sof_sdw_quirk_table

@simontrimmer
topology2: Add support for cs42l43 SKU with four host DMICs
951d0fb 
Add support for another Lenovo SKU that uses cs42l43 and four host side
DMICs rather than the CODECs DMICs.

Signed-off-by: Simon Trimmer <simont@opensource.cirrus.com>
@simontrimmer simontrimmer force-pushed the sof-lnl-cs42l43-l0-4ch branch from 41e90a0 to 951d0fb Compare November 19, 2024 16:22
@simontrimmer simontrimmer mentioned this pull request Nov 20, 2024
Merged
lgirdwood
lgirdwood approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bardliao pl review.

@lgirdwood lgirdwood merged commit ef51d72 into thesofproject:main Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bardliao bardliao bardliao approved these changes

@lgirdwood lgirdwood lgirdwood approved these changes

@ranj063 ranj063 Awaiting requested review from ranj063 ranj063 is a code owner

@jsarha jsarha Awaiting requested review from jsarha jsarha is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@simontrimmer @lgirdwood @bardliao