Audio: Crossover: Move blob configuration scripts to module directory#9215
Merged
lgirdwood merged 3 commits intothesofproject:mainfrom Sep 2, 2024
Merged
Audio: Crossover: Move blob configuration scripts to module directory#9215lgirdwood merged 3 commits intothesofproject:mainfrom
lgirdwood merged 3 commits intothesofproject:mainfrom
Conversation
To consolidate the audio moves the scripts are moved to the same directory as the module. This first step only moves the files. The next steps rename the scripts and fix possible issue to directories move. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
The paths to topology and sof-ctl blobs are updated. The paths to other setup scripts (common, eq) are set with a new helper function crossover_paths.m. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
The names are changed to avoid any collisions with multiple Octave or Matlab paths enabled. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
lgirdwood
reviewed
Jun 11, 2024
Comment on lines
+12
to
+14
| common = '../../../../tools/tune/common'; | ||
| eq = '../../../../tools/tune/eq'; | ||
| # After #9187 merge use this: |
Member
There was a problem hiding this comment.
ok, this is ok in short term, long term we will need to set a ${prefix} as a base directory via cmake (and this will help with make install too). We should also obey any rules that Matlab/Octave use for libraries of functions when it comes to storage.
cujomalainey
approved these changes
Aug 27, 2024
Contributor
cujomalainey
left a comment
There was a problem hiding this comment.
ditto to @lgirdwood's concerns about pathing, otherwise LGTM
lgirdwood
approved these changes
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.