Ignore the already safe date() function#665
Merged
silasjoisten merged 1 commit intothecodingmachine:masterfrom May 13, 2025
cedric-anne:fix/date
Merged
Ignore the already safe date() function#665silasjoisten merged 1 commit intothecodingmachine:masterfrom cedric-anne:fix/date
date() function#665silasjoisten merged 1 commit intothecodingmachine:masterfrom
cedric-anne:fix/date
Conversation
Contributor
Author
|
I put this back to draft to make a unique PR with all the fixes, in order to prevent conflicting PRs. |
date() function
Collaborator
|
@cedric-anne thank you! Can you please split this PR for each function into a different PR? |
Contributor
Author
I can, but they will conflict each other, so I will wait for each one to be merged before opening the next one. First one is #666 . |
Collaborator
|
@cedric-anne ready when you are ;) |
Collaborator
date() function
Contributor
Author
|
I rebased the current PR to include only the initial |
Collaborator
|
released in v3.2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PHP < 8.0, passing an invalid
timestampparameter value to thedate()function was triggering a warning and afalsevalue was returned.Since PHP 8.0, an error is thrown in this specific case.
Still, the corresponding PHP doc has only been fixed in PHP 8.4 and remained
Returns a formatted date string. If a non-numeric value is used for <parameter>timestamp</parameter>, &false; is returned and an <constant>E_WARNING</constant> level error is emitted.in previous PHP 8.x version.