Skip to content

Conversation

@ShooterIT
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2025

Codecov Report

❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (cluster-asm@e47f72c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/cluster_asm.c 88.88% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##             cluster-asm      #59   +/-   ##
==============================================
  Coverage               ?   69.56%           
==============================================
  Files                  ?      125           
  Lines                  ?    73875           
  Branches               ?        0           
==============================================
  Hits                   ?    51394           
  Misses                 ?    22481           
  Partials               ?        0           
Files with missing lines Coverage Δ
src/replication.c 87.05% <100.00%> (ø)
src/server.h 100.00% <ø> (ø)
src/cluster_asm.c 88.44% <88.88%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ShooterIT ShooterIT requested a review from tezc August 25, 2025 00:57
Copy link
Owner

@tezc tezc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me. I recall the similar issue with rdbchannel repl.

@ShooterIT
Copy link
Collaborator Author

I recall the similar issue with rdbchannel

yes

@ShooterIT ShooterIT merged commit ca26edd into tezc:cluster-asm Aug 25, 2025
16 of 18 checks passed
@ShooterIT ShooterIT deleted the asm-cancel branch August 25, 2025 07:17
tezc pushed a commit that referenced this pull request Sep 10, 2025
tezc pushed a commit that referenced this pull request Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants