Handle some scenarios that we need to cancel ASM #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@ShooterIT As you are working on this, I think we should also consider cancelling on FAILOVER. Master will pause writes during failover and if we complete migration during this write pause, source side will try to trim keys which will also try to write to repl log. It eventually triggers an assert here: |
Collaborator
Author
|
thanks, i missed that, you mean |
Owner
|
yes, CLUSTER FAILOVER command |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## cluster-asm #57 +/- ##
==============================================
Coverage ? 69.69%
==============================================
Files ? 125
Lines ? 73876
Branches ? 0
==============================================
Hits ? 51487
Misses ? 22389
Partials ? 0
🚀 New features to boost your workflow:
|
ShooterIT
commented
Aug 21, 2025
tezc
reviewed
Aug 21, 2025
tezc
reviewed
Aug 21, 2025
tezc
reviewed
Aug 21, 2025
tezc
approved these changes
Aug 22, 2025
tezc
pushed a commit
that referenced
this pull request
Sep 10, 2025
- CLUSTER FORGET command - CLUSTER ADDSLOTS/DELSLOTS command - CLUSTER SETSLOTS command - CLUSTER FAILOVER command - CLIENT PAUSE command - server shutdown (SHUTDOWN command or kill)
tezc
pushed a commit
that referenced
this pull request
Sep 16, 2025
- CLUSTER FORGET command - CLUSTER ADDSLOTS/DELSLOTS command - CLUSTER SETSLOTS command - CLUSTER FAILOVER command - CLIENT PAUSE command - server shutdown (SHUTDOWN command or kill)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.