Use AOF format to import data #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## cluster-asm #53 +/- ##
==============================================
Coverage ? 69.69%
==============================================
Files ? 125
Lines ? 73788
Branches ? 0
==============================================
Hits ? 51426
Misses ? 22362
Partials ? 0
🚀 New features to boost your workflow:
|
tezc
reviewed
Aug 15, 2025
src/cluster_asm.c
Outdated
| * Generally RDB binary format is more efficient, but it may cause | ||
| * block in the destination if the object is too large, so fall back | ||
| * to AOF format if necessary. */ | ||
| if ((o->type != OBJ_STRING && getObjectLength(o) <= AOF_REWRITE_ITEMS_PER_CMD) || |
Owner
There was a problem hiding this comment.
getObjectLength() will always return zero for module type. Maybe we should exclude module types from this length check.
Owner
There was a problem hiding this comment.
though, not sure how we check this for module types.
Collaborator
Author
There was a problem hiding this comment.
good catch, now for module type, if it supports aof_rewrite, we just use AOF format.
tezc
approved these changes
Aug 15, 2025
tezc
pushed a commit
that referenced
this pull request
Sep 10, 2025
tezc
pushed a commit
that referenced
this pull request
Sep 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.