Skip to content

Asm optimization #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ShooterIT merged 4 commits into from
Aug 6, 2025
Merged

Asm optimization #52

ShooterIT merged 4 commits into from
Aug 6, 2025

Conversation

@ShooterIT
Copy link
Collaborator

@ShooterIT ShooterIT commented Aug 5, 2025 •
edited
Loading

  • slot dict size hint
  • proxy importing data stream

before
asm

now
asm2

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 77.77778% with 10 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (cluster-asm@bb8d8eb). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/cluster_asm.c 80.48% 8 Missing ⚠️
src/replication.c 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff               @@
##             cluster-asm      #52   +/-   ##
==============================================
  Coverage               ?   69.45%           
==============================================
  Files                  ?      125           
  Lines                  ?    73693           
  Branches               ?        0           
==============================================
  Hits                   ?    51187           
  Misses                 ?    22506           
  Partials               ?        0
Files with missing lines Coverage Δ
src/kvstore.c 98.41% <100.00%> (ø)
src/replication.c 87.13% <33.33%> (ø)
src/cluster_asm.c 87.48% <80.48%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ShooterIT ShooterIT marked this pull request as ready for review August 6, 2025 04:12
tezc
tezc reviewed Aug 6, 2025
View reviewed changes
tezc
tezc reviewed Aug 6, 2025
View reviewed changes
tezc
tezc reviewed Aug 6, 2025
View reviewed changes
@ShooterIT
Copy link
Collaborator Author

ShooterIT commented Aug 6, 2025

thanks for reviewing. i did performance testing during migrating 100 slots, but didn't find improvement

no ASM:

======================================================================================================================================================
Type         Ops/sec     Hits/sec   Misses/sec    MOVED/sec      ASK/sec    Avg. Latency     p50 Latency     p99 Latency   p99.9 Latency       KB/sec 
------------------------------------------------------------------------------------------------------------------------------------------------------
Sets       185664.58          ---          ---         0.00         0.00         1.07799         1.05500         2.09500         2.54300     14122.26 
Gets       185661.17    185661.17         0.00         0.00         0.00         1.07700         1.05500         2.09500         2.52700     13215.45 
Waits           0.00          ---          ---          ---          ---             ---             ---             ---             ---          --- 
Totals     371325.75    185661.17         0.00         0.00         0.00         1.07749         1.05500         2.09500         2.52700     27337.71

before:

ALL STATS
======================================================================================================================================================
Type         Ops/sec     Hits/sec   Misses/sec    MOVED/sec      ASK/sec    Avg. Latency     p50 Latency     p99 Latency   p99.9 Latency       KB/sec 
------------------------------------------------------------------------------------------------------------------------------------------------------
Sets       172985.04          ---          ---        13.23         0.00         1.16976         1.11100         2.19100         3.13500     13158.12 
Gets       172976.53    172976.43         0.00         0.10         0.00         1.14304         1.11100         2.17500         3.07100     12312.57 
Waits           0.00          ---          ---          ---          ---             ---             ---             ---             ---          --- 
Totals     345961.57    172976.43         0.00        13.33         0.00         1.15640         1.11100         2.19100         3.10300     25470.69

now:

ALL STATS
======================================================================================================================================================
Type         Ops/sec     Hits/sec   Misses/sec    MOVED/sec      ASK/sec    Avg. Latency     p50 Latency     p99 Latency   p99.9 Latency       KB/sec 
------------------------------------------------------------------------------------------------------------------------------------------------------
Sets       173373.29          ---          ---        13.32         0.00         1.16778         1.11100         2.19100         3.15100     13187.63 
Gets       173364.80    173364.79         0.00         0.02         0.00         1.13987         1.11100         2.19100         3.11900     12340.19 
Waits           0.00          ---          ---          ---          ---             ---             ---             ---             ---          --- 
Totals     346738.09    173364.79         0.00        13.33         0.00         1.15382         1.11100         2.19100         3.13500     25527.83

@ShooterIT ShooterIT merged commit 6e71101 into tezc:cluster-asm Aug 6, 2025
16 of 18 checks passed
@ShooterIT ShooterIT deleted the asm-opts branch August 6, 2025 09:51
tezc pushed a commit that referenced this pull request Sep 10, 2025
@ShooterIT @tezc
Asm optimization (#52)
9a4fe29 
- slot dict size hint
- proxy importing data stream
tezc pushed a commit that referenced this pull request Sep 16, 2025
@ShooterIT @tezc
Asm optimization (#52)
b46af76 
- slot dict size hint
- proxy importing data stream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tezc tezc tezc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShooterIT @codecov-commenter @tezc