Skip to content

Conversation

@tezc
Copy link
Owner

@tezc tezc commented Jul 27, 2025

PR involves some improvements to make plugin side development easier:

  • Avoid using sds in the API. Internally, we are still using sds but in the plugin API uses char*. only.
  • Allow plugin to generate task_id for the ASM_EVENT_IMPORT_START event.
  • Error strings are stored in a static buffer in Redis to avoid requiring plugin to free it.

Copy link
Collaborator

@ShooterIT ShooterIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tezc
Copy link
Owner Author

tezc commented Jul 28, 2025

@ShooterIT I realize I forgot to add you as reviewer :)

@tezc tezc merged commit bb8d8eb into cluster-asm Jul 28, 2025
26 of 30 checks passed
@tezc tezc deleted the fix-plugin-api branch July 28, 2025 10:51
tezc added a commit that referenced this pull request Sep 10, 2025
Use basic types in cluster plugin api
tezc added a commit that referenced this pull request Sep 16, 2025
Use basic types in cluster plugin api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants