Skip to content

Filter expire #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ShooterIT merged 9 commits into from
Jul 27, 2025
Merged

Filter expire #49

ShooterIT merged 9 commits into from
Jul 27, 2025

Conversation

@ShooterIT
Copy link
Collaborator

@ShooterIT ShooterIT commented Jul 16, 2025 •
edited
Loading

  • don't expire keys for importing clients
  • skip keys that belong migration slots when active expiration
  • hfe expire
  • randomkey command
  • keys command
  • scan command
  • eviction

@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 96.92308% with 2 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (cluster-asm@4e3d7e8). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/db.c 94.73% 1 Missing ⚠️
src/kvstore.c 93.33% 1 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff               @@
##             cluster-asm      #49   +/-   ##
==============================================
  Coverage               ?   68.97%           
==============================================
  Files                  ?      125           
  Lines                  ?    73635           
  Branches               ?        0           
==============================================
  Hits                   ?    50791           
  Misses                 ?    22844           
  Partials               ?        0
Files with missing lines Coverage Δ
src/cluster_asm.c 87.69% <100.00%> (ø)
src/evict.c 96.65% <100.00%> (ø)
src/expire.c 96.01% <100.00%> (ø)
src/t_hash.c 95.70% <100.00%> (ø)
src/db.c 90.76% <94.73%> (ø)
src/kvstore.c 96.83% <93.33%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ShooterIT
Copy link
Collaborator Author

ShooterIT commented Jul 24, 2025

@tezc There are so many compromises, not sure if you like it, or you have a better idea

HFE:
eda1fe1
eviction:
0f20979

@ShooterIT ShooterIT requested a review from tezc July 24, 2025 04:03
tezc
tezc reviewed Jul 24, 2025
View reviewed changes
tezc
tezc reviewed Jul 24, 2025
View reviewed changes
tezc
tezc reviewed Jul 24, 2025
View reviewed changes
tezc
tezc reviewed Jul 24, 2025
View reviewed changes
tezc
tezc reviewed Jul 24, 2025
View reviewed changes
@ShooterIT ShooterIT merged commit d41fd1e into tezc:cluster-asm Jul 27, 2025
16 of 18 checks passed
@ShooterIT ShooterIT deleted the filter-expire branch July 27, 2025 15:24
tezc pushed a commit that referenced this pull request Sep 10, 2025
@ShooterIT @tezc
Filter expire (#49)
9856103 
don't expire keys for importing clients
skip keys that belong migration slots when active expiration
hfe expire
randomkey command
keys command
scan command
eviction
tezc pushed a commit that referenced this pull request Sep 16, 2025
@ShooterIT @tezc
Filter expire (#49)
6fbd1f8 
don't expire keys for importing clients
skip keys that belong migration slots when active expiration
hfe expire
randomkey command
keys command
scan command
eviction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tezc tezc tezc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShooterIT @codecov-commenter @tezc