Consider main channel client as replica #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShooterIT
commented
Jul 10, 2025
ShooterIT
commented
Jul 10, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## cluster-asm #47 +/- ##
==============================================
Coverage ? 69.51%
==============================================
Files ? 125
Lines ? 73571
Branches ? 0
==============================================
Hits ? 51142
Misses ? 22429
Partials ? 0
🚀 New features to boost your workflow:
|
Collaborator
Author
|
Hi @tezc after introducing task id, i think we can use task id to authenticate the rdb channel, i think it is better than client id, and consistent with CLUSTER SYNCSLOTS RANGE, WDYT? the commit is rdb channel uses task id to authenticate |
ShooterIT
commented
Jul 10, 2025
tezc
approved these changes
Jul 10, 2025
tezc
pushed a commit
that referenced
this pull request
Sep 10, 2025
* dest as replica * add test cases * Fix test cases * rdb channel uses task id to authenticate * revert syncslots-reply * task id check * use task id to find status
tezc
pushed a commit
that referenced
this pull request
Sep 16, 2025
* dest as replica * add test cases * Fix test cases * rdb channel uses task id to authenticate * revert syncslots-reply * task id check * use task id to find status
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.