refactor and fix language issues #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

tezc merged 8 commits into cluster-asm from cluster-asm-minor

Jul 7, 2025

Owner

tezc commented Jul 6, 2025 •

edited

Loading

I asked AI to review logs, comments and naming of variables/functions. So, I tried to fix some of the warnings. I don't have any strong feeling around these, so feel extra free to tell the ones you don't like. I tried to comment the reason of the change for some of them.

Changes:

Fix logs, comments, variable & function/names.
CLUSTER MIGRATION CANCEL will actually work.
Added asmTaskSetFailed() to save the error and log at the same time.
Linter issues around signed vs unsigned variable.
Fixed plugin build.


          refactor and fix language issues

6c68563

tezc commented

View reviewed changes

src/cluster.h Outdated Show resolved Hide resolved

tezc commented

View reviewed changes

src/cluster_asm.c Show resolved Hide resolved

tezc commented

View reviewed changes

src/cluster_asm.c Show resolved Hide resolved

tezc commented

View reviewed changes

src/cluster_asm.c Show resolved Hide resolved

tezc commented

View reviewed changes

src/cluster_asm.c Show resolved Hide resolved

tezc commented

View reviewed changes

src/cluster_asm.c Show resolved Hide resolved

tezc commented

View reviewed changes

src/cluster_asm.c Show resolved Hide resolved

tezc commented

View reviewed changes

src/cluster_asm.c Show resolved Hide resolved

tezc commented

View reviewed changes

src/cluster_legacy.c Show resolved Hide resolved

tezc commented

View reviewed changes

src/cluster_asm.c Show resolved Hide resolved

tezc added 5 commits

July 6, 2025 07:02


          test log

067b637


          test log

61d9148


          test log

f6c09d6


          test log

1d57c8a


          plugin fix

83fbed8

tezc marked this pull request as ready for review

July 6, 2025 04:58

tezc requested a review from ShooterIT

July 6, 2025 04:59

ShooterIT reviewed

View reviewed changes

src/cluster_legacy.c Show resolved Hide resolved

ShooterIT reviewed

View reviewed changes

src/cluster_asm.c Outdated Show resolved Hide resolved

ShooterIT reviewed

View reviewed changes

src/cluster_asm.c Outdated Show resolved Hide resolved

ShooterIT reviewed

View reviewed changes

src/cluster_asm.c Outdated Show resolved Hide resolved

ShooterIT reviewed

View reviewed changes

src/cluster_asm.c Outdated Show resolved Hide resolved

ShooterIT reviewed

View reviewed changes

src/cluster_asm.c Show resolved Hide resolved

ShooterIT reviewed

View reviewed changes

Collaborator

ShooterIT left a comment

Good job!

tezc and others added 2 commits

July 7, 2025 09:04


          Update src/cluster_asm.c

a65a433

Co-authored-by: Yuan Wang <yuan.wang@redis.com>


          comments

0c3af74

tezc requested a review from ShooterIT

July 7, 2025 12:04

ShooterIT approved these changes

View reviewed changes

tezc merged commit 7f0a9e6 into cluster-asm

46 of 48 checks passed

tezc deleted the cluster-asm-minor branch

July 7, 2025 12:55

tezc added a commit that referenced this pull request


          refactor and fix language issues (#44)

20fd636

refactor and fix language issues

Co-authored-by: Yuan Wang <yuan.wang@redis.com>

tezc added a commit that referenced this pull request


          refactor and fix language issues (#44)

58105cd

refactor and fix language issues

Co-authored-by: Yuan Wang <yuan.wang@redis.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet